Correctly handle links starting with whitespace #108129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
I have actually just checked out a new branch for fixing this before going through the mail and seeing this PR. |
|
Could you add all the test cases from #107995? /// [ Path`]
/// [ `Path`]
and #[doc = "line ["]
#[doc = "Path"]
#[doc = "] line"] |
petrochenkov
added
S-waiting-on-author
GuillaumeGomez
force-pushed
the
correctly-handle-links-starting-with-whitespace
branch
from
3e7a980 to
8d1c662
Compare
|
I added the suggested test cases. |
This comment was marked as resolved.
This comment was marked as resolved.
GuillaumeGomez
force-pushed
the
correctly-handle-links-starting-with-whitespace
branch
from
8d1c662 to
05f2fad
Compare
GuillaumeGomez
force-pushed
the
correctly-handle-links-starting-with-whitespace
branch
from
05f2fad to
8d801fd
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
This was referenced Feb 19, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 19, 2023
…llaumeGomez Rollup of 5 pull requests Successful merges: - rust-lang#107766 (Fix json reexports of different items with same name) - rust-lang#108129 (Correctly handle links starting with whitespace) - rust-lang#108188 (Change src/etc/vscode_settings.json to always treat ./library as the sysroot source) - rust-lang#108203 (Fix RPITITs in default trait methods (by assuming projection predicates in param-env)) - rust-lang#108212 (Download rustfmt regardless of rustc being set in config.toml) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
GuillaumeGomez
deleted the
correctly-handle-links-starting-with-whitespace
branch
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #107995.
I just got this issue, wrote a fix and then saw the issue. So here's the PR. ^^'
r? @petrochenkov