Skip to content

move TestHelpers to test.rs and rename native.rs to llvm.rs #108247

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 4 commits into from

Conversation

jkvargas
Copy link

@jkvargas jkvargas commented Feb 19, 2023

Fixes issse #108240

@rustbot
Copy link
Collaborator

rustbot commented Feb 19, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Feb 19, 2023
@bors
Copy link
Collaborator

bors commented Feb 22, 2023

☔ The latest upstream changes (presumably #108302) made this pull request unmergeable. Please resolve the merge conflicts.

@Mark-Simulacrum
Copy link
Member

Please squash commits. r=me with that done.

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 25, 2023
@Mark-Simulacrum
Copy link
Member

Please squash commits. r=me with that done.

@rustbot author

@bors
Copy link
Collaborator

bors commented Mar 2, 2023

☔ The latest upstream changes (presumably #107879) made this pull request unmergeable. Please resolve the merge conflicts.

# Conflicts:
#	src/bootstrap/lib.rs
#	src/bootstrap/test.rs
@rust-log-analyzer
Copy link
Collaborator

The job mingw-check failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
   Compiling xz2 v0.1.6
error[E0422]: cannot find struct, variant or union type `TestHelpers` in this scope
    --> test.rs:1438:24
     |
1438 |         builder.ensure(TestHelpers { target: compiler.host });

error[E0422]: cannot find struct, variant or union type `TestHelpers` in this scope
    --> test.rs:1442:28
     |
---
  --> lib.rs:63:1
   |
63 | mod test;
   | ^^^^^^^^^
   = note: `-D unused-imports` implied by `-D warnings`
For more information about this error, try `rustc --explain E0422`.
error: could not compile `bootstrap` due to 3 previous errors
failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
Build completed unsuccessfully in 0:00:20
Build completed unsuccessfully in 0:00:20
make: *** [Makefile:58: prepare] Error 1
Command failed. Attempt 2/5:
Building bootstrap
   Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0422]: cannot find struct, variant or union type `TestHelpers` in this scope
    --> test.rs:1438:24
     |
1438 |         builder.ensure(TestHelpers { target: compiler.host });

error[E0422]: cannot find struct, variant or union type `TestHelpers` in this scope
    --> test.rs:1442:28
     |
---
  --> lib.rs:63:1
   |
63 | mod test;
   | ^^^^^^^^^
   = note: `-D unused-imports` implied by `-D warnings`
For more information about this error, try `rustc --explain E0422`.
error: could not compile `bootstrap` due to 3 previous errors
failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
Build completed unsuccessfully in 0:00:01
Build completed unsuccessfully in 0:00:01
make: *** [Makefile:58: prepare] Error 1
Command failed. Attempt 3/5:
Building bootstrap
   Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0422]: cannot find struct, variant or union type `TestHelpers` in this scope
    --> test.rs:1438:24
     |
1438 |         builder.ensure(TestHelpers { target: compiler.host });

error[E0422]: cannot find struct, variant or union type `TestHelpers` in this scope
    --> test.rs:1442:28
     |
---
  --> lib.rs:63:1
   |
63 | mod test;
   | ^^^^^^^^^
   = note: `-D unused-imports` implied by `-D warnings`
For more information about this error, try `rustc --explain E0422`.
error: could not compile `bootstrap` due to 3 previous errors
failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
Build completed unsuccessfully in 0:00:01
Build completed unsuccessfully in 0:00:01
make: *** [Makefile:58: prepare] Error 1
Command failed. Attempt 4/5:
Building bootstrap
   Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0422]: cannot find struct, variant or union type `TestHelpers` in this scope
    --> test.rs:1438:24
     |
1438 |         builder.ensure(TestHelpers { target: compiler.host });

error[E0422]: cannot find struct, variant or union type `TestHelpers` in this scope
    --> test.rs:1442:28
     |
---
  --> lib.rs:63:1
   |
63 | mod test;
   | ^^^^^^^^^
   = note: `-D unused-imports` implied by `-D warnings`
For more information about this error, try `rustc --explain E0422`.
error: could not compile `bootstrap` due to 3 previous errors
failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
Build completed unsuccessfully in 0:00:01
Build completed unsuccessfully in 0:00:01
make: *** [Makefile:58: prepare] Error 1
Command failed. Attempt 5/5:
Building bootstrap
   Compiling bootstrap v0.0.0 (/checkout/src/bootstrap)
error[E0422]: cannot find struct, variant or union type `TestHelpers` in this scope
    --> test.rs:1438:24
     |
1438 |         builder.ensure(TestHelpers { target: compiler.host });

error[E0422]: cannot find struct, variant or union type `TestHelpers` in this scope
    --> test.rs:1442:28
     |
---
  --> lib.rs:63:1
   |
63 | mod test;
   | ^^^^^^^^^
   = note: `-D unused-imports` implied by `-D warnings`
For more information about this error, try `rustc --explain E0422`.
error: could not compile `bootstrap` due to 3 previous errors
failed to run: /checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo build --manifest-path /checkout/src/bootstrap/Cargo.toml --locked
Build completed unsuccessfully in 0:00:01

@jkvargas
Copy link
Author

Closing this since I created a new PR #109649

@jkvargas jkvargas closed this Mar 27, 2023
@jkvargas jkvargas deleted the fix_108240 branch March 27, 2023 04:38
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants