Skip to content

Add regression test for #107918 #108431

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Feb 26, 2023

Conversation

GuillaumeGomez
Copy link
Member

Fixes #107918.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Feb 24, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 24, 2023

📌 Commit 37d4302 has been approved by notriddle

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Feb 24, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2023
@notriddle
Copy link
Contributor

@bors r-

Never mind. This test case doesn't actually reproduce the problem.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 24, 2023
@GuillaumeGomez
Copy link
Member Author

GuillaumeGomez commented Feb 24, 2023

What do you mean?

EDIT: I'll re-check with the version which failed soon.

@notriddle
Copy link
Contributor

It works. It just took me awhile to figure out how to actually reproduce it locally.

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 24, 2023

📌 Commit 37d4302 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 24, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 24, 2023
…-107918, r=notriddle

Add regression test for rust-lang#107918

Fixes rust-lang#107918.

r? `@notriddle`
@matthiaskrgr
Copy link
Member

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 25, 2023
@GuillaumeGomez
Copy link
Member Author

Let's retry.

@bors r=notriddle rollup

@bors
Copy link
Collaborator

bors commented Feb 25, 2023

📌 Commit c934ee8 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Feb 25, 2023
…-107918, r=notriddle

Add regression test for rust-lang#107918

Fixes rust-lang#107918.

r? `@notriddle`
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Feb 25, 2023
…-107918, r=notriddle

Add regression test for rust-lang#107918

Fixes rust-lang#107918.

r? ``@notriddle``
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 26, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#107062 (Do some cleanup of doc/index.md)
 - rust-lang#107890 (Lint against `Iterator::map` receiving a callable that returns `()`)
 - rust-lang#108431 (Add regression test for rust-lang#107918)
 - rust-lang#108432 (test: drop unused deps)
 - rust-lang#108436 (make "proc macro panicked" translatable)
 - rust-lang#108444 (docs/test: add UI test and docs for `E0476`)
 - rust-lang#108449 (Do not lint ineffective unstable trait impl for unresolved trait)
 - rust-lang#108456 (Complete migrating `ast_passes` to derive diagnostics)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 5196e91 into rust-lang:master Feb 26, 2023
@rustbot rustbot added this to the 1.69.0 milestone Feb 26, 2023
@GuillaumeGomez GuillaumeGomez deleted the regression-test-for-107918 branch February 26, 2023 09:45
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cargo doc fails on found duplicate lang item 'panic_impl' dependency issue (no_std)
5 participants