Skip to content

Rollup of 9 pull requests #108509

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 96 commits into from

Conversation

matthiaskrgr
Copy link
Member

Successful merges:

Failed merges:

r? @ghost
@rustbot modify labels: rollup

Create a similar rollup

RalfJung and others added 30 commits January 13, 2023 11:45
add scfix test

I'm not sure if we currently *guarantee* to pass this test, but at least I was unable to get it to fail.

Cc `@cbeuw`
It was broken, and the fixed version actually fails...
remove scfix test

It was broken, and the fixed version actually fails...

Thanks `@cbeuw` !
Co-authored-by: Ralf Jung <post@ralfj.de>
Explain how to make josh authenticate with github via ssh

Without this I was unable to push, even though pushing directly to https without josh works.
RalfJung and others added 11 commits February 26, 2023 19:09
Implement read_buf for a few more types

Implement read_buf for TcpStream, Stdin, StdinLock, ChildStdout,
ChildStderr (and internally for AnonPipe, Handle, Socket), so
that it skips buffer initialization.

The other provided methods like read_to_string and read_to_end are
implemented in terms of read_buf and so benefit from the optimization
as well.

This commit also implements read_vectored and is_read_vectored where
applicable.
…, r=compiler-errors

Unify validity checks into a single query

Previously, there were two queries to check whether a type allows the 0x01 or zeroed bitpattern.

I am planning on adding a further initness to check in rust-lang#100423, truly uninit for MaybeUninit, which would make this three queries. This seems overkill for such a small feature, so this PR unifies them into one.

I am not entirely happy with the naming and key type and open for improvements.

r? oli-obk
add llvm cgu instructions stats to perf

r? `@bjorn3`
…lbertlarsan68

bootstrap: Update the output of the `check` descriptions

This should bring the output from `x check` in line with the changes in rust-lang#108171
…r=compiler-errors

Make `match` arm comma suggestion more clear

Fixes rust-lang#108472
Merge diagnostic_items duplicate diagnostics

To deduplicate how we diagnose duplication.
…ddle

Clean up JS files code a bit

I mostly moved values closer to where they are used to make the code reading easier.

r? `@notriddle`
@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. rollup A PR which is a rollup labels Feb 26, 2023
@matthiaskrgr
Copy link
Member Author

@bors r+ rollup=never p=9

@bors
Copy link
Collaborator

bors commented Feb 26, 2023

📌 Commit 80f2908 has been approved by matthiaskrgr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 26, 2023
@bors
Copy link
Collaborator

bors commented Feb 27, 2023

⌛ Testing commit 80f2908 with merge 8994db744ec85d260280c824d975d8524334be4b...

@rust-log-analyzer
Copy link
Collaborator

The job test-various failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)
[RUSTC-TIMING] gimli test:false 5.831
[RUSTC-TIMING] object test:false 6.971
warning: dropping unsupported crate type `dylib` for target `wasm32-unknown-unknown`

error[E0599]: no method named `read_buf` found for struct `sys::wasm::net::TcpStream` in the current scope
    |
    |
623 |         self.0.read_buf(buf)
    |
    |
   ::: library/std/src/sys/wasm/../unsupported/net.rs:7:1
    |
7   | pub struct TcpStream(!);
    | -------------------- method `read_buf` not found for this struct
    = help: items from traits can only be used if the trait is implemented and in scope
    = help: items from traits can only be used if the trait is implemented and in scope
note: `io::Read` defines an item `read_buf`, perhaps you need to implement it
    |
554 | pub trait Read {
    | ^^^^^^^^^^^^^^


error[E0599]: no method named `read_buf` found for struct `sys::wasm::net::TcpStream` in the current scope
    |
    |
661 |         self.0.read_buf(buf)
    |
    |
   ::: library/std/src/sys/wasm/../unsupported/net.rs:7:1
    |
7   | pub struct TcpStream(!);
    | -------------------- method `read_buf` not found for this struct
    = help: items from traits can only be used if the trait is implemented and in scope
    = help: items from traits can only be used if the trait is implemented and in scope
note: `io::Read` defines an item `read_buf`, perhaps you need to implement it
    |
554 | pub trait Read {
    | ^^^^^^^^^^^^^^

@bors
Copy link
Collaborator

bors commented Feb 27, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 27, 2023
@matthiaskrgr matthiaskrgr deleted the rollup-3433g3a branch March 16, 2024 18:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.