Skip to content

[beta] stage0 bump and backports #108670

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 8 commits into from
Mar 4, 2023
Merged

[beta] stage0 bump and backports #108670

merged 8 commits into from
Mar 4, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Mar 2, 2023 •
edited
Loading

r? @ghost

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue. labels Mar 2, 2023
@rustbot

This comment was marked as off-topic.

# to view
@cuviper
Copy link
Member Author

cuviper commented Mar 2, 2023

cc @rust-lang/release
@bors r+ rollup=never p=1

@bors
Copy link
Collaborator

bors commented Mar 2, 2023

📌 Commit 10c7cf3ef9c5604b9d3978a410a477139e1508e2 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2023
@bors
Copy link
Collaborator

bors commented Mar 2, 2023

⌛ Testing commit 10c7cf3ef9c5604b9d3978a410a477139e1508e2 with merge 54eb4635e48f2e7026d73f7cae84458aa1c3e18e...

@bors
Copy link
Collaborator

bors commented Mar 2, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 2, 2023
@cuviper
Copy link
Member Author

cuviper commented Mar 2, 2023

Several "GitHub Actions has encountered an internal error when running your job."

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 2, 2023
@rust-log-analyzer

This comment has been minimized.

# to view
@cuviper
Copy link
Member Author

cuviper commented Mar 3, 2023

Holding off so I can add a couple more...

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 3, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 3, 2023

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@cuviper cuviper mentioned this pull request Mar 3, 2023
Merged
cuviper and others added 6 commits March 3, 2023 09:32
@cuviper
Bump stage0 to stable
40cb3f0
@ChrisDenton @cuviper
Revert to using RtlGenRandom
a541751 
This is required due to `BCryptGenRandom` failing to load the necessary dll on some systems.

(cherry picked from commit dfd0afb)
@Sp00ph @cuviper
Fix VecDeque::shrink_to and add tests.
a07453a 
This adds both a test specific to rust-lang#108453 as well as an exhaustive test
that goes through all possible combinations of head index, length and target capacity
for a deque with capacity 16.

(cherry picked from commit 9e22516)
@Sp00ph @cuviper
Disambiguate comments
2d33fe7 
(cherry picked from commit 4a4f43e)
@pommicket @cuviper
Use checked_add in VecDeque::append for ZSTs to avoid overflow
07a8043 
(cherry picked from commit 379b18b)
@pommicket @cuviper
Add test for VecDeque::append ZST capacity overflow
005892a 
(cherry picked from commit 12f959b)
@cuviper
Copy link
Member Author

cuviper commented Mar 3, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented Mar 3, 2023

📌 Commit be90b53 has been approved by cuviper

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 3, 2023
@bors
Copy link
Collaborator

bors commented Mar 4, 2023

⌛ Testing commit be90b53 with merge 47a8fce...

@bors
Copy link
Collaborator

bors commented Mar 4, 2023

☀️ Test successful - checks-actions
Approved by: cuviper
Pushing 47a8fce to beta...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 4, 2023
@bors bors merged commit 47a8fce into rust-lang:beta Mar 4, 2023
@rustbot rustbot added this to the 1.68.0 milestone Mar 4, 2023
This was referenced Mar 4, 2023
Closed
Closed
@pietroalbini
Copy link
Member

It seems like the backport of #108673 is incorrect? You added the tests to tests/ui-toml, not src/tools/clippy/tests/ui-toml.

@cuviper
Copy link
Member Author

cuviper commented Mar 7, 2023

Ah, whoops -- I just cherry-picked that, but actually #108673 had it that way too. I guess git-subtree confused things when grabbing it from the rust-clippy repo.

@pietroalbini
Copy link
Member

Actually, it seems like the PR to master is also affected #108674 (comment)

@cuviper cuviper deleted the beta-next branch April 26, 2023 23:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. T-release Relevant to the release subteam, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.68.0
Development

Successfully merging this pull request may close these issues.
10 participants
@cuviper @rustbot @bors @rust-log-analyzer @pietroalbini @ChrisDenton @Sp00ph @pommicket @Alexendoo @compiler-errors