Skip to content

Improve documentation and argument naming of some TyCtxt methods #108770

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2023
Merged

Improve documentation and argument naming of some TyCtxt methods #108770

merged 1 commit into from
Mar 6, 2023

Conversation

GuillaumeGomez
Copy link
Member

I got bit by this recently so better prevent others to end up the same as me.

@rustbot
Copy link
Collaborator

rustbot commented Mar 5, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 5, 2023
@cjgillot
Copy link
Contributor

cjgillot commented Mar 5, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Mar 5, 2023

📌 Commit 1836fe4 has been approved by cjgillot

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 5, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 5, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 6, 2023
@bors
Auto merge of rust-lang#108789 - matthiaskrgr:rollup-nyurto8, r=matth…
8c0f83d 
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108244 (Add test for semicolon recovery ICE)
 - rust-lang#108746 (Don't project to RPITIT that has no default value)
 - rust-lang#108764 (Tweaks to -Zdrop-tracking-mir)
 - rust-lang#108770 (Improve documentation and argument naming of some TyCtxt methods)
 - rust-lang#108773 (x fmt: Only check modified files locally)
 - rust-lang#108775 (Use the correct bound vars in return type suggestion.)
 - rust-lang#108776 (Make `x test tidy` less noisy)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 970f263 into rust-lang:master Mar 6, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 6, 2023
@GuillaumeGomez GuillaumeGomez deleted the improve-doc-and-naming branch March 6, 2023 09:56
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@jackh726 jackh726

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
5 participants
@GuillaumeGomez @rustbot @cjgillot @bors @jackh726