-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Decouple test
and proc_macro
#108871
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Decouple test
and proc_macro
#108871
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
These commits modify the If this was intentional then you can ignore this comment. Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
These commits modify the If this was intentional then you can ignore this comment. |
@jyn514 You'll want to look at the error on the first commit. The second is my attempted fix. |
@Zoxc you can use |
I'll have to remove the ability to document individual crates then, as different crates may have different sets of features. |
I think it would be possible to change which |
I'm going to favor #108865 then as I'd prefer not to reimplement cargo features in bootstrap. Ideally cargo would have to ability to specify features for a whole workspace here. |
This decouples the
test
andproc_macro
crates by havingbootstrap
build both at the same time instead of havingproc_macro
be a dependency oftest
. This allows them to build in parallel saving around 9 seconds locally.The
std
is also built directly bybootstrap
avoiding the extra features on thetest
crate.This is an alternative to #108865.