Skip to content

ci: use apt install --download-only for solaris debs #108951

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 10, 2023
Merged

ci: use apt install --download-only for solaris debs #108951

merged 1 commit into from
Mar 10, 2023

Conversation

cuviper
Copy link
Member

@cuviper cuviper commented Mar 9, 2023

No description provided.

@rustbot
Copy link
Collaborator

rustbot commented Mar 9, 2023

r? @pietroalbini

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 9, 2023
@cuviper cuviper mentioned this pull request Mar 9, 2023
Merged
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup=never p=150

@bors
Copy link
Collaborator

bors commented Mar 10, 2023

📌 Commit 258c7e7 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Mar 10, 2023

🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2023
@bors
Copy link
Collaborator

bors commented Mar 10, 2023

⌛ Testing commit 258c7e7 with merge f37f854...

@matthiaskrgr
Copy link
Member

@bors treeclosed-

@bors
Copy link
Collaborator

bors commented Mar 10, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing f37f854 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 10, 2023
@bors bors merged commit f37f854 into rust-lang:master Mar 10, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 10, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f37f854): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -0.5% [-0.5%, -0.5%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -1.6% [-1.9%, -1.3%] 2
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

@cuviper cuviper deleted the solaris-debs branch March 11, 2023 18:45
@Mark-Simulacrum Mark-Simulacrum added beta-nominated Nominated for backporting to the compiler in the beta channel. beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Mar 16, 2023
@Mark-Simulacrum Mark-Simulacrum modified the milestones: 1.70.0, 1.68.0, 1.69.0 Mar 16, 2023
@Noratrieb Noratrieb mentioned this pull request Mar 20, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 20, 2023
@bors
Auto merge of rust-lang#109335 - Mark-Simulacrum:stable-next, r=Mark-…
8460ca8 
…Simulacrum

[stable] 1.68.1 release

This packages up a set of release notes, version bump, and backports of:

* Don't eagerly convert principal to string rust-lang#108162
*  Revert "enable ThinLTO for rustc on x86_64-pc-windows-msvc dist builds" rust-lang#109094
*  Create dirs for build_triple rust-lang#109111
*  Fix linker detection for clang with prefix rust-lang#109156
*  ci: use apt install --download-only for solaris debs rust-lang#108951

The last of those is not yet stable-accepted but I expect it to be, we will drop it and rebuild artifacts if we don't actually approve it.

r? `@Mark-Simulacrum`
thirteenowls added a commit to thirteenowls/cross that referenced this pull request May 17, 2024
@thirteenowls
Fix *-solaris targets
c81946b 
Adapted from rust-lang/rust#108951 and rust-lang/rust#81229.
@thirteenowls thirteenowls mentioned this pull request May 17, 2024
Merged
github-merge-queue bot pushed a commit to cross-rs/cross that referenced this pull request May 17, 2024
@Emilgardis
Fix *-solaris targets (#1495)
19be834 
Fixes #1424.

Adapted from rust-lang/rust#108951 and
rust-lang/rust#81229 (with some minor changes to
satisfy ShellCheck and account for broken symlinks).

This PR also renames `x86_64-sun-solaris` to `x86_64-pc-solaris`, as the
former was [deprecated](rust-lang/rust#82216) in
Rust 1.52.0 and [removed](rust-lang/rust#118091)
in Rust 1.76.0, making this a breaking change.
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@pietroalbini pietroalbini

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc beta-accepted Accepted for backporting to the compiler in the beta channel. merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.69.0
Development

Successfully merging this pull request may close these issues.
7 participants
@cuviper @rustbot @Mark-Simulacrum @bors @matthiaskrgr @rust-timer @pietroalbini