Skip to content

Limit the number of parallel link jobs during LLVM build for mingw. #109073

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

michaelwoerister
Copy link
Member

This PR is an attempt to unblock #108355, which keeps failing while trying to link various LLVM artifacts on mingw runners. It looks like doing too many linking jobs might put too much load on the system? (Although I don't understand why the jobs are only failing for #108355 while they seem to pass for others)

r? infra-ci

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 13, 2023
@michaelwoerister michaelwoerister force-pushed the limit-mingw-llvm-link-jobs branch from 118a1a3 to 3b172f7 Compare March 13, 2023 10:42
@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Mar 13, 2023
@michaelwoerister michaelwoerister force-pushed the limit-mingw-llvm-link-jobs branch from 3b172f7 to 307dc1a Compare March 14, 2023 10:20
@@ -59,6 +59,12 @@ RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-locked-deps"
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-cargo-native-static"
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-units-std=1"

# When building for mingw, limit the number of parallel linker jobs during
# the LLVM build, as not to run out of memory.
if isWindows && [[ ${CUSTOM_MINGW-0} -eq 1 ]]; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check is copied from

elif isWindows && [[ ${CUSTOM_MINGW-0} -ne 1 ]]; then
.

@Mark-Simulacrum
Copy link
Member

cc #108227 which is the tracking issue for this spurious failure

I don't mind trying this, but I think we should link the tracking issue for the spurious failure from the code for the future visitor who is confused. r=me with that added.

@Mark-Simulacrum
Copy link
Member

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 18, 2023
This is an attempt to fix the spurious build error tracked by
rust-lang#108227.
@michaelwoerister michaelwoerister force-pushed the limit-mingw-llvm-link-jobs branch from 307dc1a to 40fc423 Compare March 20, 2023 09:51
@michaelwoerister
Copy link
Member Author

Thanks, @Mark-Simulacrum!

@bors r=Mark-Simulacrum

@bors
Copy link
Collaborator

bors commented Mar 20, 2023

📌 Commit 40fc423 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 20, 2023
@michaelwoerister
Copy link
Member Author

@bors p=1 since this might potentially resolve #108227, which is slowing down the whole build queue.

@bors
Copy link
Collaborator

bors commented Mar 22, 2023

⌛ Testing commit 40fc423 with merge 6502613...

@bors
Copy link
Collaborator

bors commented Mar 22, 2023

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing 6502613 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 22, 2023
@bors bors merged commit 6502613 into rust-lang:master Mar 22, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 22, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (6502613): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.5% [0.5%, 0.5%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.2% [-2.4%, -0.8%] 4
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.8% [0.4%, 2.3%] 6
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants