-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Limit the number of parallel link jobs during LLVM build for mingw. #109073
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Limit the number of parallel link jobs during LLVM build for mingw. #109073
Conversation
118a1a3
to
3b172f7
Compare
3b172f7
to
307dc1a
Compare
@@ -59,6 +59,12 @@ RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-locked-deps" | |||
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --enable-cargo-native-static" | |||
RUST_CONFIGURE_ARGS="$RUST_CONFIGURE_ARGS --set rust.codegen-units-std=1" | |||
|
|||
# When building for mingw, limit the number of parallel linker jobs during | |||
# the LLVM build, as not to run out of memory. | |||
if isWindows && [[ ${CUSTOM_MINGW-0} -eq 1 ]]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This check is copied from
rust/src/ci/scripts/install-clang.sh
Line 40 in 0058748
elif isWindows && [[ ${CUSTOM_MINGW-0} -ne 1 ]]; then |
cc #108227 which is the tracking issue for this spurious failure I don't mind trying this, but I think we should link the tracking issue for the spurious failure from the code for the future visitor who is confused. r=me with that added. |
@rustbot author |
This is an attempt to fix the spurious build error tracked by rust-lang#108227.
307dc1a
to
40fc423
Compare
Thanks, @Mark-Simulacrum! @bors r=Mark-Simulacrum |
☀️ Test successful - checks-actions |
Finished benchmarking commit (6502613): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
This PR is an attempt to unblock #108355, which keeps failing while trying to link various LLVM artifacts on mingw runners. It looks like doing too many linking jobs might put too much load on the system? (Although I don't understand why the jobs are only failing for #108355 while they seem to pass for others)
r? infra-ci