Rollup of 10 pull requests #109189
Closed
Rollup of 10 pull requests #109189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scaping bound vars
…r=GuillaumeGomez rustdoc: fix type search for `Option` combinators
…s, r=WaffleLapkin error-msg: impl better suggestion for `E0532` Fixes rust-lang#106862 No test as there is already a test which is nearly identical to the example in the linked issue.
…t-for-write, r=notriddle rustdoc: DocFS: Replace rayon with threadpool and enable it for all targets Fixes rust-lang#109060. Switching to `threadpool` makes it a bit simpler for us to wait for all tasks in `DocFS` directly in the `Drop` implementation. I'm also curious if making all the writes into a thread pool could improve run time for rustdoc on all other platforms than Windows as well. I'll run a perf check to see. cc `@ehuss` r? `@notriddle`
…, r=WaffleLapkin Assert def-kind is correct for alias types Make sure we're not constructing alias types for the wrong def-kind, at least for debug cases 😅
… r=oli-obk make `define_opaque_types` fully explicit based on the idea of rust-lang#108389. Moved `define_opaque_types` into the actual operations, e.g. `eq`, instead of `infcx.at` because normalization doesn't use `define_opaque_types` and even creates it's own `At` with a different `define_opaque_types` internally. Somewhat surprisingly, coherence actually relies on `DefineOpaqueTypes::Yes` for soundness which was revealed because I've incorrectly used `DefineOpaqueTypes::No` in `equate_impl_headers`. It feels concerning that even though this is the case, we still sometimes use `DefineOpaqueTypes::No` in coherence. I did not look into this as part of this PR as it is purely changing the structure of the code without changing behavior in any way. r? `@oli-obk`
…ompiler-errors Some cleanups in our normalization logic Changed a match to be exhaustive and deduplicated some code. r? `@compiler-errors` this pulls out the uncontroversial part of rust-lang#108860
…, r=WaffleLapkin mv tests/codegen/issue-* tests/codegen/issues/ No changes to the contents; just a move. Like how there's a <https://github.com/rust-lang/rust/tree/master/tests/ui/issues> folder.
Unequal → Not equal Fixes rust-lang#109168
Revert rust-lang#107376 to fix potential `bincode` breakage and `rustc-perf` benchmark. rust-lang#107376 caused `rustc-perf`'s `webrender` benchmark to break, by regressing on the `bincode-1.3.3` crate. ~~This PR is a draft revert in case we can't land a fix soon enough, and we'd like to land the revert instead~~ (Though I myself think it'd be safer to do the revert, and run crater when relanding rust-lang#107376.) cc `@aliemjay`
…tip, r=jsha rustdoc: remove `std::` from primitive intra-doc link tooltips Take the intra-doc link to the method `iter` from https://doc.rust-lang.org/nightly/std/slice/struct.Iter.html Before: `method std::slice::iter` After: `method slice::iter`
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=10 |
bors
added
S-waiting-on-bors
|
⌛ Testing commit a350c76 with merge 9039dfbea2b5a6155836b43d94b0974c9f6ae8b0... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
bors
added
S-waiting-on-bors
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
⌛ Testing commit a350c76 with merge 1d5d9febed579f0a55ac13de7a37b1991091fcd5... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
@bors retry failed to build llvm |
bors
added
S-waiting-on-bors
|
⌛ Testing commit a350c76 with merge 2fa3dc2709a6dc82474f094a2b33b539bda1dc73... |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
Optioncombinators #108875 (rustdoc: fix type search forOptioncombinators)E0532#108971 (error-msg: impl better suggestion forE0532)define_opaque_typesfully explicit #109166 (makedefine_opaque_typesfully explicit)bincodebreakage andrustc-perfbenchmark. #109183 (Revert remove obsoletegivensfrom regionck #107376 to fix potentialbincodebreakage andrustc-perfbenchmark.)std::from primitive intra-doc link tooltips #109185 (rustdoc: removestd::from primitive intra-doc link tooltips)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup