-
Notifications
You must be signed in to change notification settings - Fork 13.4k
Rollup of 9 pull requests #109284
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rollup of 9 pull requests #109284
Conversation
Print at least the Some/None/Ok/Err status of the nested bindings if not the bindings themselves.
Co-authored-by: Waffle Maybe <waffle.lapkin@gmail.com>
…-lt-binder, r=jackh726 Erase escaping late-bound regions when probing for ambiguous associated types Fixes rust-lang#109090
…ffleLapkin Fix index out of bounds in `suggest_trait_fn_ty_for_impl_fn_infer` Fixes rust-lang#109191
…tion, r=WaffleLapkin E0206 - update description added `union` to description
…trochenkov Do not ICE for unexpected lifetime with ConstGeneric rib Fixes rust-lang#109143 r? ````@petrochenkov```` Combining this test with the previous test will affect the previous diagnostics, so I added a separate test case.
fallback to lstat when stat fails on Windows Fixes rust-lang#109106 ````@ChrisDenton```` please let me know if this is the expected behavior for stat on windows
…=WaffleLapkin Pass the right HIR back from `get_fn_decl` Fixes rust-lang#109232 Makes sure that the `fn_id: HirId` that we pass to `suggest_missing_return_type` matches up with the `fn_decl: hir::FnDecl` that we pass to it, so the late-bound vars that we fetch from the former match up with the types in the latter... This HIR suggestion code really needs a big refactor. I've tried to do it in the past (a couple of attempts), but it's a super tangled mess. It really shouldn't be passing around things like `hir::Node` and just deal with `LocalDefId`s everywhere... Anyways, I'd rather fix this ICE, now.
Suggest surrounding the macro with `{}` to interpret as a statement Fixes rust-lang#109237
…san68 Check for llvm-tools before install Fixes rust-lang#108948 ````@jpalus```` Please review
resolve: Improve debug impls for `NameBinding` Print at least the Some/None/Ok/Err status of the nested bindings if not the bindings themselves. Noticed while reviewing rust-lang#108729.
@bors r+ rollup=never p=9 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: 13afbdaa06 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (85123d2): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
Successful merges:
suggest_trait_fn_ty_for_impl_fn_infer
#109200 (Fix index out of bounds insuggest_trait_fn_ty_for_impl_fn_infer
)get_fn_decl
#109248 (Pass the right HIR back fromget_fn_decl
){}
to interpret as a statement #109251 (Suggest surrounding the macro with{}
to interpret as a statement)NameBinding
#109257 (resolve: Improve debug impls forNameBinding
)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup