Skip to content

Remove Ty::is_region_ptr #109378

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 23, 2023
Merged

Remove Ty::is_region_ptr #109378

merged 1 commit into from
Mar 23, 2023

Conversation

mu001999
Copy link
Contributor

Fixes #109372

@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2023

r? @wesleywiser

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 20, 2023
@rustbot
Copy link
Collaborator

rustbot commented Mar 20, 2023

Some changes occurred in compiler/rustc_codegen_cranelift

cc @bjorn3

@mu001999
Copy link
Contributor Author

r? @compiler-errors

@scottmcm
Copy link
Member

Since CI came in clean,
@bors r+

Thanks for picking this up!

@bors
Copy link
Collaborator

bors commented Mar 20, 2023

📌 Commit 20dc532 has been approved by scottmcm

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 21, 2023
@Dylan-DPC
Rollup merge of rust-lang#109378 - MU001999:master, r=scottmcm
4159409 
Remove Ty::is_region_ptr

Fixes rust-lang#109372
This was referenced Mar 21, 2023
Closed
Closed
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 22, 2023
@Dylan-DPC
Rollup merge of rust-lang#109378 - MU001999:master, r=scottmcm
7297fe4 
Remove Ty::is_region_ptr

Fixes rust-lang#109372
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 22, 2023
Merged
@compiler-errors
Copy link
Member

@bors rollup

bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 23, 2023
@bors
Auto merge of rust-lang#109503 - matthiaskrgr:rollup-cnp7kdd, r=matth…
84dd6df 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#108954 (rustdoc: handle generics better when matching notable traits)
 - rust-lang#109203 (refactor/feat: refactor identifier parsing a bit)
 - rust-lang#109213 (Eagerly intern and check CrateNum/StableCrateId collisions)
 - rust-lang#109358 (rustc: Remove unused `Session` argument from some attribute functions)
 - rust-lang#109359 (Update stdarch)
 - rust-lang#109378 (Remove Ty::is_region_ptr)
 - rust-lang#109423 (Use region-erased self type during IAT selection)
 - rust-lang#109447 (new solver cleanup + implement coherence)
 - rust-lang#109501 (make link clickable)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2ee07a1 into rust-lang:master Mar 23, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 23, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

[cleanup] Ty::is_ref and Ty::is_region_ptr are identical
7 participants
@mu001999 @rustbot @scottmcm @bors @compiler-errors @Noratrieb @wesleywiser