Skip to content

Avoid ICE of attempt to add with overflow in emitter #109403

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 21, 2023
Merged

Avoid ICE of attempt to add with overflow in emitter #109403

merged 1 commit into from
Mar 21, 2023

Conversation

chenyukang
Copy link
Member

Fixes #109396
r? @estebank

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 20, 2023
@estebank
Copy link
Contributor

@bors r+

It does seem like the suggestion itself should also be fixed, because it leaves a stray comma, but that's a separate issue.

@bors
Copy link
Collaborator

bors commented Mar 20, 2023

📌 Commit cbb8066 has been approved by estebank

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 20, 2023
@chenyukang chenyukang mentioned this pull request Mar 21, 2023
Closed
@chenyukang
Copy link
Member Author

@bors r+

It does seem like the suggestion itself should also be fixed, because it leaves a stray comma, but that's a separate issue.

created another issue: #109425

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 21, 2023
@matthiaskrgr
Rollup merge of rust-lang#109403 - chenyukang:yukang/fix-109396, r=es…
c3f18ef 
…tebank

Avoid ICE of attempt to add with overflow in emitter

Fixes rust-lang#109396
r? `@estebank`
This was referenced Mar 21, 2023
Closed
Closed
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Mar 21, 2023
@matthiaskrgr
Rollup merge of rust-lang#109403 - chenyukang:yukang/fix-109396, r=es…
0271c1c 
…tebank

Avoid ICE of attempt to add with overflow in emitter

Fixes rust-lang#109396
r? ``@estebank``
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 21, 2023
@bors
Auto merge of rust-lang#109453 - matthiaskrgr:rollup-odn02wu, r=matth…
1db9c06 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#96391 (Windows: make `Command` prefer non-verbatim paths)
 - rust-lang#108164 (Drop all messages in bounded channel when destroying the last receiver)
 - rust-lang#108729 (fix: modify the condition that `resolve_imports` stops)
 - rust-lang#109336 (Constrain const vars to error if const types are mismatched)
 - rust-lang#109403 (Avoid ICE of attempt to add with overflow in emitter)
 - rust-lang#109415 (Refactor `handle_missing_lit`.)
 - rust-lang#109441 (Only implement Fn* traits for extern "Rust" safe function pointers and items)
 - rust-lang#109446 (Do not suggest bounds restrictions for synthesized RPITITs)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 25b062d into rust-lang:master Mar 21, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 21, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

ICE: attempt to add with overflow emitter.rs
4 participants
@chenyukang @estebank @bors @rustbot