LIBPATH is used as dylib's path environment variable on AIX #109526
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
bjorn3
reviewed
Mar 25, 2023
rustbot
added
the
A-testsuite
| @@ -741,6 +741,9 @@ def build_bootstrap(self, color, verbose_count): | |||
| env["LIBRARY_PATH"] = os.path.join(self.bin_root(), "lib") + \ | |||
| (os.pathsep + env["LIBRARY_PATH"]) \ | |||
| if "LIBRARY_PATH" in env else "" | |||
| env["LIBPATH"] = os.path.join(self.bin_root(), "lib") + \ | |||
| (os.pathsep + env["LIBPATH"]) \ | |||
| if "LIBPATH" in env else "" | |||
There was a problem hiding this comment.
Seems OK to me - src/tools/cargo/crates/cargo-util/src/paths.rs also may want a similar change.
|
@bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 2, 2023
LIBPATH is used as dylib's path environment variable on AIX See https://4js.com/online_documentation/fjs-fgl-3.00.05-manual-html/c_fgl_installation_017.html.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 3, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#109526 (LIBPATH is used as dylib's path environment variable on AIX) - rust-lang#109642 (check for missing codegen backeng config) - rust-lang#109722 (Implement read_buf for RustHermit) - rust-lang#109856 (fix(middle): emit error rather than delay bug when reaching limit) - rust-lang#109868 (Improve PR job names in Github Actions preview) - rust-lang#109871 (Include invocation start times) - rust-lang#109873 (Move some UI tests into subdirectories) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang/cargo
that referenced
this pull request
May 25, 2023
fix: AIX searches dynamic libraries in `LIBPATH`. ### What does this PR try to resolve? On IBM AIX machines people have encountered issues in `compiletest` and rustc's bootstrap builder. They haven't encountered any in cargo. This PR is made for avoiding potential failures in the future in cargo. It's documented in <https://www.ibm.com/support/pages/libpath-environment-variables-aix-platforms>: > The `LIBPATH` environment variable tells AIX applications where to find shared libraries when located in a different directories than those specified in the header section of the executable. See also the counterpart in <rust-lang/rust#109526> ### How to verify and test this in Cargo's CI? This is indeed an issue. At IBM people are maintaining a buildbot since GitHub Action doesn't support AIX yet.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://4js.com/online_documentation/fjs-fgl-3.00.05-manual-html/c_fgl_installation_017.html.