Skip to content

Use an IndexVec to debug fingerprints. #109587

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 27, 2023
Merged

Use an IndexVec to debug fingerprints. #109587

merged 1 commit into from
Mar 27, 2023

Conversation

cjgillot
Copy link
Contributor

Uncontroversial part of #109050

@rustbot
Copy link
Collaborator

rustbot commented Mar 25, 2023

r? @Nilstrieb

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Mar 25, 2023
Noratrieb
Noratrieb approved these changes Mar 25, 2023
View reviewed changes
Copy link
Member

@Noratrieb Noratrieb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me

@cjgillot
Copy link
Contributor Author

@bors r=Nilstrieb

@bors
Copy link
Collaborator

bors commented Mar 25, 2023

📌 Commit 5e49f09 has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 25, 2023
@bors
Copy link
Collaborator

bors commented Mar 26, 2023

⌛ Testing commit 5e49f09 with merge 2f11ced9556fc639c063c540a2adf93831c12383...

@bors
Copy link
Collaborator

bors commented Mar 26, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 26, 2023
@ehuss
Copy link
Contributor

ehuss commented Mar 26, 2023

@bors retry

#108227 since LLVM update

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 26, 2023
@rust-log-analyzer
Copy link
Collaborator

The job dist-i686-mingw failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
[2510/3103] Linking CXX static library lib\libLLVMBitReader.a
[2511/3103] Linking CXX static library lib\libLLVMFrontendHLSL.a
[2512/3103] Linking CXX static library lib\libLLVMCFGuard.a
[2513/3103] Linking CXX static library lib\libLLVMMCA.a
FAILED: lib/libLLVMMCA.a 
cmd.exe /C "cd . && "C:\Program Files\CMake\bin\cmake.exe" -E rm -f lib\libLLVMMCA.a && C:\a\rust\rust\mingw32\bin\ar.exe qc lib\libLLVMMCA.a  lib/MCA/CMakeFiles/LLVMMCA.dir/CodeEmitter.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Context.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/CustomBehaviour.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/HWEventListener.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/HardwareUnits/HardwareUnit.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/HardwareUnits/LSUnit.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/HardwareUnits/RegisterFile.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/HardwareUnits/ResourceManager.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/HardwareUnits/RetireControlUnit.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/HardwareUnits/Scheduler.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/IncrementalSourceMgr.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/InstrBuilder.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Instruction.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Pipeline.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Stages/DispatchStage.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Stages/EntryStage.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Stages/ExecuteStage.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Stages/InOrderIssueStage.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Stages/InstructionTables.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Stages/MicroOpQueueStage.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Stages/RetireStage.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Stages/Stage.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/Support.cpp.obj lib/MCA/CMakeFiles/LLVMMCA.dir/View.cpp.obj && C:\a\rust\rust\mingw32\bin\ranlib.exe lib\libLLVMMCA.a && cd ."
C:\a\rust\rust\mingw32\bin\ar.exe: could not create temporary file whilst writing archive: no more archived files
[2514/3103] Building CXX object lib/TextAPI/CMakeFiles/LLVMTextAPI.dir/TextStubCommon.cpp.obj
[2515/3103] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/FDRTraceExpander.cpp.obj
[2516/3103] Linking CXX static library lib\libLLVMAArch64Info.a
[2517/3103] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/FDRRecords.cpp.obj
[2517/3103] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/FDRRecords.cpp.obj
[2518/3103] Building CXX object lib/ToolDrivers/llvm-dlltool/CMakeFiles/LLVMDlltoolDriver.dir/DlltoolDriver.cpp.obj
[2519/3103] Building CXX object lib/XRay/CMakeFiles/LLVMXRay.dir/FileHeaderReader.cpp.obj
[2520/3103] Building CXX object lib/ToolDrivers/llvm-lib/CMakeFiles/LLVMLibDriver.dir/LibDriver.cpp.obj
ninja: build stopped: subcommand failed.
command did not execute successfully, got: exit code: 1


build script failed, must exit now', C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1cd66030c949c28d\cmake-0.1.48\src\lib.rs:975:5
 finished in 314.983 seconds
Build completed unsuccessfully in 0:08:02

Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request Mar 27, 2023
@Dylan-DPC
Rollup merge of rust-lang#109587 - cjgillot:no-hashmap-fingerprint, r…
6371b91 
…=Nilstrieb

Use an IndexVec to debug fingerprints.

Uncontroversial part of rust-lang#109050
@Dylan-DPC Dylan-DPC mentioned this pull request Mar 27, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 27, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 27, 2023
@bors
Auto merge of rust-lang#109652 - matthiaskrgr:rollup-pbw3hi3, r=matth…
553ecbe 
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#97506 (Stabilize `nonnull_slice_from_raw_parts`)
 - rust-lang#98651 (Follow C-RW-VALUE in std::io::Cursor example)
 - rust-lang#102742 (Remove unnecessary raw pointer in __rust_start_panic arg)
 - rust-lang#109587 (Use an IndexVec to debug fingerprints.)
 - rust-lang#109613 (fix type suggestions in match arms)
 - rust-lang#109633 (Fix "Directly go to item in search if there is only one result" setting)
 - rust-lang#109635 (debuginfo: Get pointer size/align from tcx.data_layout instead of layout_of)
 - rust-lang#109641 (Don't elaborate non-obligations into obligations)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 32aa4c0 into rust-lang:master Mar 27, 2023
@rustbot rustbot added this to the 1.70.0 milestone Mar 27, 2023
@cjgillot cjgillot deleted the no-hashmap-fingerprint branch March 27, 2023 15:43
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Noratrieb Noratrieb Noratrieb approved these changes

Assignees

@Noratrieb Noratrieb

Labels
A-query-system Area: The rustc query system (https://rustc-dev-guide.rust-lang.org/query.html) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cjgillot @rustbot @bors @ehuss @rust-log-analyzer @Noratrieb