Rollup of 6 pull requests #109626
Merged
Rollup of 6 pull requests #109626
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since structs are always `VariantIdx(0)`, there's a bunch of files where the only reason they had `VariantIdx` or `vec::Idx` imported at all was to get the first variant. So this uses a constant for that, and adds some doc-comments to `VariantIdx` while I'm there, since it doesn't have any today.
Don't display `// some variants omitted` if enum is marked `#[non_exhaustive]`
…ed, r=notriddle,GuillaumeGomez rustdoc: skip `// some variants omitted` if enum is `#[non_exhaustive]` Fixes rust-lang#108925 Never touched rustdoc before so probably not the best code. cc `@dtolnay`
… r=GuillaumeGomez Rustdoc Book refer to rustdoc::missing_doc_code_examples. Fixes rust-lang#109592. Fixes rust-lang#109592. But, please see a related question at rust-lang#109592 (item `2.`).
…to-hide-trait, r=notriddle Improve "Auto-hide trait implementation documentation" GUI test Part of rust-lang#66181. I'll start working on the `include` command for `browser-ui-test` so we can greatly reduce the duplicated code between setting tests. r? ``@notriddle``
…urther-specializable, r=BoxyUwU Still-further-specializable projections are ambiguous in new solver Fixes https://github.com/rust-lang/rust/pull/108896/files#r1148450781 r? ``@BoxyUwU`` (though feel free to re-roll) --- This can be used to create an unsound transmute function with the new solver: ```rust #![feature(specialization)] trait Default { type Id; fn intu(&self) -> &Self::Id; } impl<T> Default for T { default type Id = T; fn intu(&self) -> &Self::Id { self } } fn transmute<T: Default<Id = U>, U: Copy>(t: T) -> U { *t.intu() } use std::num::NonZeroU8; fn main() { let s = transmute::<u8, Option<NonZeroU8>>(0); assert_eq!(s, None); } ```
Correct typo (`back_box` -> `black_box`)
…iler-errors Refactor: `VariantIdx::from_u32(0)` -> `FIRST_VARIANT` Since structs are always `VariantIdx(0)`, there's a bunch of files where the only reason they had `VariantIdx` or `vec::Idx` imported at all was to get the first variant. So this uses a constant for that, and adds some doc-comments to `VariantIdx` while I'm there, since [it doesn't have any today](https://doc.rust-lang.org/nightly/nightly-rustc/rustc_target/abi/struct.VariantIdx.html).
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=6 |
|
🌲 The tree is currently closed for pull requests below priority 100. This pull request will be tested once the tree is reopened. |
bors
added
S-waiting-on-bors
|
@bors p=100 we can just retry it til it passes 😆 |
|
⌛ Testing commit 4aa4ce6 with merge 4f0507aad366046e514126574b7097fde8907558... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 4aa4ce6 with merge e793849e24b429f95cdeca0f7ee7c87ca5ed6657... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
well it was worth a shot @bors p=6 retry |
bors
added
S-waiting-on-bors
|
@bors retry p=101 |
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR: previous master: 2420bd34ba In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Mar 26, 2023
|
Finished benchmarking commit (89c2e3d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
// some variants omittedif enum is#[non_exhaustive]#109007 (rustdoc: skip// some variants omittedif enum is#[non_exhaustive])missing_doc_code_exampleswithrustdoc::missing_doc_code_examples#109592.)back_box->black_box) #109620 (Correct typo (back_box->black_box))VariantIdx::from_u32(0)->FIRST_VARIANT#109621 (Refactor:VariantIdx::from_u32(0)->FIRST_VARIANT)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup