Don't ICE on DiscriminantKind projection in new solver
#109748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
|
@bors r+ rollup (limited to new solver) |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 30, 2023
Rollup of 7 pull requests Successful merges: - rust-lang#106985 (Enhanced doucmentation of binary search methods for `slice` and `VecDeque` for unsorted instances) - rust-lang#109509 (compiletest: Don't allow tests with overlapping prefix names) - rust-lang#109719 (RELEASES: Add "Only support Android NDK 25 or newer" to 1.68.0) - rust-lang#109748 (Don't ICE on `DiscriminantKind` projection in new solver) - rust-lang#109749 (Canonicalize float var as float in new solver) - rust-lang#109761 (Drop binutils on powerpc-unknown-freebsd) - rust-lang#109766 (Fix title for openharmony.md) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says, since we now actually call
Ty::discriminant_kindon placeholder types 😃Also drive-by simplify
Pointee::Metadataprojection logic, and fix the UI test because the<T as Pointee>::Metadatatests weren't actually exercising the new projection logic, since we still eagerly normalize (which hitsproject.rsin the old solver) in HIR typeck.r? @lcnr tho feel free to re-roll, this pr is very low-priority and not super specific to the new trait solver.
Fixes compiler-errors/next-solver-hir-issues#14