-
Notifications
You must be signed in to change notification settings - Fork 13.3k
rustc_middle: Document which exactly DefId
s don't have DefKind
s
#109778
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @lcnr (rustbot has picked a reviewer for you, use r? to override) |
r? @cjgillot maybe |
I'm not convinced this is the right direction. I'd suggest the opposite: all |
But that's exactly what my FIXME comment says. |
Indeed, I need to re-learn how to read... |
rustc_middle: Document which exactly `DefId`s don't have `DefKind`s I don't currently have time to investigate when and how to create these missing HIR nodes, but if someone else could do that it would be great.
☀️ Test successful - checks-actions |
1 similar comment
☀️ Test successful - checks-actions |
Finished benchmarking commit (5ca6e98): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
|
I don't currently have time to investigate when and how to create these missing HIR nodes, but if someone else could do that it would be great.