Skip to content

Fix non_exhaustive_omitted_patterns on arguments and locals #109836

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 2, 2023

Conversation

clubby789
Copy link
Contributor

Fixes #99815

r? @Nilstrieb

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 1, 2023
@Noratrieb
Copy link
Member

r=me after CI is happy
@bors delegate+

@bors
Copy link
Collaborator

bors commented Apr 1, 2023

✌️ @clubby789 can now approve this pull request

@clubby789 clubby789 force-pushed the param-non-exhaustive branch from 79b5996 to bcbefe0 Compare April 1, 2023 17:44
@clubby789 clubby789 changed the title Fix non_exhaustive_omitted_patterns on arguments Fix non_exhaustive_omitted_patterns on arguments and locals Apr 1, 2023
@clubby789 clubby789 force-pushed the param-non-exhaustive branch from bcbefe0 to 46f7d3d Compare April 1, 2023 18:15
@clubby789
Copy link
Contributor Author

@bors r=Nilstrieb

@bors
Copy link
Collaborator

bors commented Apr 1, 2023

📌 Commit 46f7d3d has been approved by Nilstrieb

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 1, 2023
@bors
Copy link
Collaborator

bors commented Apr 2, 2023

⌛ Testing commit 46f7d3d with merge f5f93d0...

@bors
Copy link
Collaborator

bors commented Apr 2, 2023

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing f5f93d0 to master...

1 similar comment
@bors
Copy link
Collaborator

bors commented Apr 2, 2023

☀️ Test successful - checks-actions
Approved by: Nilstrieb
Pushing f5f93d0 to master...

@bors bors added merged-by-bors This PR was explicitly merged by bors. labels Apr 2, 2023
@bors bors merged commit f5f93d0 into rust-lang:master Apr 2, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 2, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (f5f93d0): comparison URL.

Overall result: ❌✅ regressions and improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.0% [2.0%, 2.0%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-1.2% [-1.2%, -1.2%] 1
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
2.3% [2.3%, 2.3%] 1
Improvements ✅
(primary)
-2.5% [-2.5%, -2.5%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -2.5% [-2.5%, -2.5%] 1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
1.7% [1.3%, 2.1%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 1.7% [1.3%, 2.1%] 2

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

False positive on non_exhaustive_omitted_patterns_lint with closures
5 participants