Skip to content

Deny useing tool paths #109909

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 6, 2023
Merged

Deny useing tool paths #109909

merged 1 commit into from
Apr 6, 2023

Conversation

clubby789
Copy link
Contributor

Fixes #109853
Fixes #109147

@rustbot
Copy link
Collaborator

rustbot commented Apr 3, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 3, 2023
petrochenkov
petrochenkov reviewed Apr 4, 2023
View reviewed changes
@petrochenkov petrochenkov added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 4, 2023
@clubby789
Copy link
Contributor Author

clubby789 commented Apr 4, 2023 •
edited
Loading

Moved to checking if opt_ns is None in maybe_resolve_path. I also flipped a length check which looked overflow-susceptible and made the diagnostic trasnlatable

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 4, 2023
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Collaborator

bors commented Apr 5, 2023

📌 Commit ebde2ab has been approved by petrochenkov

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 5, 2023
@JohnTitor JohnTitor mentioned this pull request Apr 5, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 5, 2023
@bors
Auto merge of rust-lang#109986 - JohnTitor:rollup-3aax38t, r=JohnTitor
8c7ad16 
Rollup of 7 pull requests

Successful merges:

 - rust-lang#109909 (Deny `use`ing tool paths)
 - rust-lang#109921 (Don't ICE when encountering `dyn*` in statics or consts)
 - rust-lang#109922 (Disable `has_thread_local` on OpenHarmony)
 - rust-lang#109926 (write threads info into log only when debugging)
 - rust-lang#109968 (Add regression test for rust-lang#80409)
 - rust-lang#109969 (Add regression test for rust-lang#86351)
 - rust-lang#109973 (rustdoc: Improve logo display very small screen)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit ea92090 into rust-lang:master Apr 6, 2023
@rustbot rustbot added this to the 1.70.0 milestone Apr 6, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@petrochenkov petrochenkov petrochenkov left review comments

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.70.0
Development

Successfully merging this pull request may close these issues.

ICE: no type-dependent def for method ICE path with 'Res::Err' but no error emitted / broken mir : --edition=2018
4 participants
@clubby789 @rustbot @petrochenkov @bors