Remove .. from return type notation
#110203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Looks good, thanks! @bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 12, 2023
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#110153 (Fix typos in compiler) - rust-lang#110165 (rustdoc: use CSS `overscroll-behavior` instead of JavaScript) - rust-lang#110175 (Symbol cleanups) - rust-lang#110203 (Remove `..` from return type notation) - rust-lang#110205 (rustdoc: make settings radio and checks thicker, less contrast) - rust-lang#110222 (Improve the error message when forwarding a matched fragment to another macro) - rust-lang#110237 (Split out a separate feature gate for impl trait in associated types) - rust-lang#110241 (tidy: Issue an error when UI test limits are too high) Failed merges: - rust-lang#110218 (Remove `ToRegionVid`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
May 15, 2023
Parse associated return type bounds This PR implements parser support for associated return type bounds: `T: Foo<bar(): Send>`. This PR does not implement associated return types (`T::bar(): Send`) because it's not implemented even in rustc, and also removes `(..)`-style return type notation because it has been removed in rust-lang/rust#110203 (effectively reverting #14465). I don't plan to proactively follow this unstable feature unless an RFC is accepted and my main motivation here is to remove no-longer-valid syntax `(..)` from our parser, nevertheless adding minimal parser support so anyone interested (as can be seen in #14465) can experiment it without rust-analyzer's syntax errors.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nikomatsakis and I decided that using
..in the return-type notation syntax is probably overkill.r? @eholk since you reviewed the last one
Since this is piggybacking now totally off of a pre-existing syntax (parenthesized generics), let me know if you need any explanation of the logic here, since it's a bit more complicated now.