Skip to content

Add a failing rustdoc-ui test for public infinite recursive type #110488

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 18, 2023
Merged

Add a failing rustdoc-ui test for public infinite recursive type #110488

merged 1 commit into from
Apr 18, 2023

Conversation

GuillaumeGomez
Copy link
Member

As suggested in #110450 (comment).

r? @jyn514

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Apr 18, 2023
jyn514
jyn514 reviewed Apr 18, 2023
View reviewed changes
Copy link
Member

@jyn514 jyn514 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you ❤️ do you mind also moving tests/rustdoc-ui/infinite-recursive-type-impl-trait.rs to this error-in-impl-trait subdirectory while you're at it?

@GuillaumeGomez GuillaumeGomez force-pushed the test-infinite-recursive-type branch from e878e10 to 4fab87d Compare April 18, 2023 12:13
@GuillaumeGomez GuillaumeGomez force-pushed the test-infinite-recursive-type branch from 4fab87d to ca882c0 Compare April 18, 2023 12:13
@jyn514
Copy link
Member

jyn514 commented Apr 18, 2023

Thank you! r=me with CI passing

@GuillaumeGomez
Copy link
Member Author

Didn't even have time to write a message to say it was updated. You're too fast! 😆

@GuillaumeGomez
Copy link
Member Author

@bors r=jyn514 rollup

@bors
Copy link
Collaborator

bors commented Apr 18, 2023

📌 Commit ca882c0 has been approved by jyn514

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Apr 18, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 18, 2023
@bors
Auto merge of rust-lang#110492 - GuillaumeGomez:rollup-n4tpbl4, r=Gui…
4e46301 
…llaumeGomez

Rollup of 5 pull requests

Successful merges:

 - rust-lang#110417 (Spelling compiler)
 - rust-lang#110441 (5 little typos)
 - rust-lang#110485 (Fix bootstrap locking)
 - rust-lang#110488 (Add a failing rustdoc-ui test for public infinite recursive type)
 - rust-lang#110490 (Bump `download-ci-llvm-stamp` for loong support)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 7e50336 into rust-lang:master Apr 18, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 18, 2023
@GuillaumeGomez GuillaumeGomez deleted the test-infinite-recursive-type branch April 19, 2023 08:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jyn514 jyn514 jyn514 left review comments

Assignees

@jyn514 jyn514

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @jyn514 @bors @rustbot