Skip to content

Remove find_map_relevant_impl #110514

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged

Conversation

compiler-errors
Copy link
Member

Fixes #108895

@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2023

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) labels Apr 19, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 19, 2023

Some changes occurred to the core trait solver

cc @rust-lang/initiative-trait-system-refactor

.unwrap()
.into_buffer()
)),
let secondary_span = (|| {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a stable "try" "block" :⁾

@rust-log-analyzer

This comment has been minimized.

@rust-cloud-vms rust-cloud-vms bot force-pushed the remove-find_map_relevant_impl branch from fd81a19 to 1467877 Compare April 19, 2023 02:08
@compiler-errors
Copy link
Member Author

oh yeah, @vincenzopalazzo said they wanted to see this PR.

Copy link
Contributor

@b-naber b-naber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.

@b-naber
Copy link
Contributor

b-naber commented Apr 22, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 22, 2023

📌 Commit 1467877 has been approved by b-naber

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 22, 2023
…levant_impl, r=b-naber

Remove `find_map_relevant_impl`

Fixes rust-lang#108895
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 22, 2023
…levant_impl, r=b-naber

Remove `find_map_relevant_impl`

Fixes rust-lang#108895
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Apr 22, 2023
…levant_impl, r=b-naber

Remove `find_map_relevant_impl`

Fixes rust-lang#108895
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 23, 2023
…levant_impl, r=b-naber

Remove `find_map_relevant_impl`

Fixes rust-lang#108895
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2023
…levant_impl, r=b-naber

Remove `find_map_relevant_impl`

Fixes rust-lang#108895
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 24, 2023
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110255 (Suggest using integration tests for test crate using own proc-macro)
 - rust-lang#110514 (Remove `find_map_relevant_impl`)
 - rust-lang#110566 (Don't create projection ty for const projection)
 - rust-lang#110637 (Group some sections of our logs in github actions)
 - rust-lang#110706 (Add `intrinsics::transmute_unchecked`)
 - rust-lang#110714 (Normalize types and consts in MIR opts.)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit d60c64a into rust-lang:master Apr 24, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 24, 2023
@compiler-errors compiler-errors deleted the remove-find_map_relevant_impl branch August 11, 2023 20:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

remove find_map_relevant_impl
5 participants