Skip to content

Update cargo #110653

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Apr 22, 2023
Merged

Update cargo #110653

merged 1 commit into from
Apr 22, 2023

Conversation

weihanglo
Copy link
Member

14 commits in d0a4cbcee614fdb7ba66e860e603a00a644d71f8..de80432f04da61d98dcbbc1572598071718ccfd2
2023-04-16 17:42:50 +0000 to 2023-04-21 13:18:32 +0000

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

⚠️ Warning ⚠️

  • These commits modify submodules.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 21, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 21, 2023

Some changes occurred in src/tools/cargo

cc @ehuss

@weihanglo
Copy link
Member Author

No risky change found in this submodule update.

@bors r+ p=1

@bors
Copy link
Collaborator

bors commented Apr 21, 2023

📌 Commit 2e2cee5 has been approved by weihanglo

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 21, 2023
@bors
Copy link
Collaborator

bors commented Apr 21, 2023

⌛ Testing commit 2e2cee5 with merge 0fd50f3...

@bors
Copy link
Collaborator

bors commented Apr 22, 2023

☀️ Test successful - checks-actions
Approved by: weihanglo
Pushing 0fd50f3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 22, 2023
@bors bors merged commit 0fd50f3 into rust-lang:master Apr 22, 2023
@rustbot rustbot added this to the 1.71.0 milestone Apr 22, 2023
@weihanglo weihanglo deleted the update-cargo branch April 22, 2023 00:06
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (0fd50f3): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-0.4% [-0.4%, -0.4%] 1
Improvements ✅
(secondary)
-1.4% [-1.4%, -1.4%] 1
All ❌✅ (primary) -0.4% [-0.4%, -0.4%] 1

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
1.4% [1.4%, 1.4%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
-2.1% [-2.1%, -2.1%] 1
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

matthiaskrgr pushed a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2023
…, r=ehuss

bootstrap: update paths cargo-credential crate

This should be done in rust-lang#110653 but forgot.

Fixes rust-lang#110742

## How to verify this patch

Run `./x.py build cargo`. Previously it would fail with

```console
error: manifest path `/projects/rust/src/tools/cargo/crates/credential/cargo-credential-1password/Cargo.toml` does not exist
```
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2023
…, r=ehuss

bootstrap: update paths cargo-credential crate

This should be done in rust-lang#110653 but forgot.

Fixes rust-lang#110742

## How to verify this patch

Run `./x.py build cargo`. Previously it would fail with

```console
error: manifest path `/projects/rust/src/tools/cargo/crates/credential/cargo-credential-1password/Cargo.toml` does not exist
```
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Apr 24, 2023
…, r=ehuss

bootstrap: update paths cargo-credential crate

This should be done in rust-lang#110653 but forgot.

Fixes rust-lang#110742

## How to verify this patch

Run `./x.py build cargo`. Previously it would fail with

```console
error: manifest path `/projects/rust/src/tools/cargo/crates/credential/cargo-credential-1password/Cargo.toml` does not exist
```
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Apr 24, 2023
…, r=ehuss

bootstrap: update paths cargo-credential crate

This should be done in rust-lang#110653 but forgot.

Fixes rust-lang#110742

## How to verify this patch

Run `./x.py build cargo`. Previously it would fail with

```console
error: manifest path `/projects/rust/src/tools/cargo/crates/credential/cargo-credential-1password/Cargo.toml` does not exist
```
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants