Skip to content

Limit lifetime of format_args!() with inlined args. #110770

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
May 9, 2023
Merged

Limit lifetime of format_args!() with inlined args. #110770

merged 1 commit into from
May 9, 2023

Conversation

m-ou-se
Copy link
Member

@m-ou-se m-ou-se commented Apr 24, 2023 •
edited
Loading

Fixes #110769

@m-ou-se m-ou-se added the A-fmt Area: `core::fmt` label Apr 24, 2023
@rustbot
Copy link
Collaborator

rustbot commented Apr 24, 2023

r? @scottmcm

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 24, 2023
@m-ou-se m-ou-se mentioned this pull request Apr 27, 2023
Open
56 tasks
@m-ou-se m-ou-se force-pushed the fmt-temp-lifetime branch from 7aca10c to d5843dd Compare May 9, 2023 14:08
@m-ou-se m-ou-se marked this pull request as ready for review May 9, 2023 14:11
@rustbot

This comment was marked as resolved.

# to view
@m-ou-se
Copy link
Member Author

m-ou-se commented May 9, 2023

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned scottmcm May 9, 2023
@m-ou-se m-ou-se mentioned this pull request May 9, 2023
Closed
@oli-obk
Copy link
Contributor

oli-obk commented May 9, 2023

r=me with a regression test added

@m-ou-se
Copy link
Member Author

m-ou-se commented May 9, 2023 •
edited
Loading

I already included such a test, as a compile_fail doc test: https://github.com/rust-lang/rust/pull/110770/files#diff-4fbe4e316a3fa623f3edea42a8d3ab2ec54de32c3ec8e46e5d5d58a562a86813

@oli-obk
Copy link
Contributor

oli-obk commented May 9, 2023

That you did, I just didn't realize it was more than good documentation

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 9, 2023

📌 Commit d5843dd has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 9, 2023

🌲 The tree is currently closed for pull requests below priority 1000. This pull request will be tested once the tree is reopened.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 9, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 9, 2023
@matthiaskrgr
Rollup merge of rust-lang#110770 - m-ou-se:fmt-temp-lifetime, r=oli-obk
1eb209a 
Limit lifetime of format_args!() with inlined args.

Fixes rust-lang#110769
@matthiaskrgr matthiaskrgr mentioned this pull request May 9, 2023
Closed
@matthiaskrgr matthiaskrgr mentioned this pull request May 9, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request May 9, 2023
@bors
Auto merge of rust-lang#111402 - matthiaskrgr:rollup-28cqfz5, r=matth…
2f6bc5d 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#97320 (Stabilize const_ptr_read)
 - rust-lang#110770 (Limit lifetime of format_args!() with inlined args.)
 - rust-lang#111021 (Move some tests)
 - rust-lang#111215 (Various changes to name resolution of anon consts)
 - rust-lang#111242 (support set `rpath` option  for each target independently)
 - rust-lang#111282 (Remove some `assume`s from slice iterators that don't do anything)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit e4c8250 into rust-lang:master May 9, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 9, 2023
@m-ou-se m-ou-se deleted the fmt-temp-lifetime branch May 10, 2023 10:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@oli-obk oli-obk

Labels
A-fmt Area: `core::fmt` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.71.0
Development

Successfully merging this pull request may close these issues.

format_args!() inlining/flattening allows for longer lifetimes
5 participants
@m-ou-se @rustbot @oli-obk @bors @scottmcm