Rollup of 6 pull requests #110924

matthiaskrgr · 2023-04-28T05:34:05Z

Successful merges:

More core::fmt::rt cleanup. #110766 (More core::fmt::rt cleanup.)
Migrate trivially translatable rustc_parse diagnostics #110873 (Migrate trivially translatable rustc_parse diagnostics)
rustdoc: rebind bound vars to type-outlives predicates #110904 (rustdoc: rebind bound vars to type-outlives predicates)
Add some missing built-in lints #110913 (Add some missing built-in lints)
remove_dir_all: try deleting the directory even if FILE_LIST_DIRECTORY access is denied #110918 (remove_dir_all: try deleting the directory even if FILE_LIST_DIRECTORY access is denied)
Fix unavailable url #110920 (Fix unavailable url)

Failed merges:

r? @ghost
@rustbot modify labels: rollup

This moves more of the internal/lang items into the private rt module.

If opening a directory with `FILE_LIST_DIRECTORY` access fails then we should try opening without requesting that access. We may still be able to delete it if it's empty or a link.

Signed-off-by: cui fliter <imcusg@gmail.com>

More core::fmt::rt cleanup. - Removes the `V1` suffix from the `Argument` and `Flag` types. - Moves more of the format_args lang items into the `core::fmt::rt` module. (The only remaining lang item in `core::fmt` is `Arguments` itself, which is a public type.) Part of rust-lang#99012 Follow-up to rust-lang#110616

…ial, r=compiler-errors Migrate trivially translatable `rustc_parse` diagnostics cc rust-lang#100717 Migrate diagnostics in `rustc_parse` which are emitted in a single statement. I worked on this by expanding the lint introduced in rust-lang#108760, although that isn't included here as there is much more work to be done to satisfy it

…ler-errors rustdoc: rebind bound vars to type-outlives predicates Fixes rust-lang#110900.

…ilstrieb Add some missing built-in lints (and also sort them, so this is best reviewed one commit at a time) Fixes rust-lang#110911 I wonder if there's a good way to detect when a lint is built-in (i.e. not associated to a lint pass). If so, it needs to be added to this list, or else we're unable to `allow` or `deny` it. Leaving that for future work, I guess...

…r=cuviper `remove_dir_all`: try deleting the directory even if `FILE_LIST_DIRECTORY` access is denied If opening a directory with `FILE_LIST_DIRECTORY` access fails then we should try opening without requesting that access. We may still be able to delete it if it's empty or a link. Fixes rust-lang/cargo#12042

Fix unavailable url The previous link is no longer accessible (404). Use latest link.

matthiaskrgr · 2023-04-28T05:34:36Z

@bors r+ rollup=never p=6

bors · 2023-04-28T05:34:38Z

📌 Commit dda1494 has been approved by matthiaskrgr

It is now in the queue for this repository.

bors · 2023-04-28T06:32:05Z

⌛ Testing commit dda1494 with merge 2fce229...

bors · 2023-04-28T09:26:51Z

☀️ Test successful - checks-actions
Approved by: matthiaskrgr
Pushing 2fce229 to master...

rust-timer · 2023-04-28T09:28:35Z

📌 Perf builds for each rolled up PR:

PR#	Perf Build Sha
#110920	3a0c906ae486f267e8bd2b2f8504c5052f6ffbaf
#110918	f9ee960d224a9220c799bd35ded29bc6495cda98
#110913	9c618d7f54a5a8ce68a74baeacd5d19f47113124
#110904	e9e99370b2e54c49e0cf62bad907f04f155464bf
#110873	8ce2bfb3ecfe391452a0a21911b2f6dd1a6668b6
#110766	b7a84c66e7e86f530ceac94f72f04792a906ea61

previous master: 033aa092ab

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2023-04-28T10:41:50Z

Finished benchmarking commit (2fce229): comparison URL.

Overall result: ❌ regressions - ACTION NEEDED

Next Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please open an issue or create a new PR that fixes the regressions, add a comment linking to the newly created issue or PR, and then add the perf-regression-triaged label to this PR.

@rustbot label: +perf-regression
cc @rust-lang/wg-compiler-performance

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.6%	[0.4%, 0.7%]	7
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	0.6%	[0.4%, 0.7%]	7

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.4%	[0.1%, 0.7%]	2
Regressions ❌ (secondary)	2.0%	[1.0%, 2.4%]	6
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-1.0%	[-1.0%, -1.0%]	1
All ❌✅ (primary)	0.4%	[0.1%, 0.7%]	2

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[1.0%, 1.0%]	1

pnkfelix · 2023-05-03T04:08:05Z

primary regressions are to debug profiles for serde_derive, hyper (plus noise from clap and cargo).
we've recovered the loss on serde_derive since this commit landed, but not on hyper.
from reviewing the PRs in the rollup, it does not seem like there's any real culprit here.
marking as triaged.

@rustbot label: perf-regression-triaged

m-ou-se and others added 18 commits April 24, 2023 16:16

Remove "V1" from ArgumentsV1 and FlagsV1.

5cf3cbf

Restructure std::fmt::rt a bit.

0a28977

This moves more of the internal/lang items into the private rt module.

Update tests.

9cc5949

Update miri test.

7bae143

Migrate trivially translatable rustc_parse diagnostics

1ce9d72

pub -> pub(super).

52ff751

rustdoc: rebind bound vars to type-outlives predicates

34d9688

Add invalid_macro_export_arguments to built-in macro list

183c790

Sort hardwired lints

3793263

Add a few more missing lints

0279922

remove_dir_all: delete directory with fewer perms

ddff7f0

If opening a directory with `FILE_LIST_DIRECTORY` access fails then we should try opening without requesting that access. We may still be able to delete it if it's empty or a link.

Fix unavailable url

176144e

Signed-off-by: cui fliter <imcusg@gmail.com>

Rollup merge of rust-lang#110904 - fmease:rustdoc-fix-110900, r=compi…

8ce92da

…ler-errors rustdoc: rebind bound vars to type-outlives predicates Fixes rust-lang#110900.

Rollup merge of rust-lang#110920 - cuishuang:master, r=jyn514

dda1494

Fix unavailable url The previous link is no longer accessible (404). Use latest link.

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 28, 2023

bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 28, 2023

bors merged commit 2fce229 into rust-lang:master Apr 28, 2023

rustbot added this to the 1.71.0 milestone Apr 28, 2023

This was referenced Apr 28, 2023

On nightly, dump ICE backtraces to disk #108714

Merged

Remove type ascription from parser and diagnostics #109128

Merged

[master] Bump stage0 #110643

Merged

Populate effective visibilities in 'rustc_privacy' #110907

Merged

rustbot added the perf-regression Performance regression. label Apr 28, 2023

rustbot added the perf-regression-triaged The performance regression has been triaged. label May 3, 2023

matthiaskrgr deleted the rollup-jvznpq2 branch March 16, 2024 18:19

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Rollup of 6 pull requests #110924

Rollup of 6 pull requests #110924

Uh oh!

matthiaskrgr commented Apr 28, 2023

Uh oh!

matthiaskrgr commented Apr 28, 2023

Uh oh!

bors commented Apr 28, 2023

Uh oh!

bors commented Apr 28, 2023

Uh oh!

bors commented Apr 28, 2023

Uh oh!

rust-timer commented Apr 28, 2023

Uh oh!

rust-timer commented Apr 28, 2023

Uh oh!

pnkfelix commented May 3, 2023

Uh oh!

Uh oh!

Rollup of 6 pull requests #110924

Rollup of 6 pull requests #110924

Uh oh!

Conversation

matthiaskrgr commented Apr 28, 2023

Uh oh!

matthiaskrgr commented Apr 28, 2023

Uh oh!

bors commented Apr 28, 2023

Uh oh!

bors commented Apr 28, 2023

Uh oh!

bors commented Apr 28, 2023

Uh oh!

rust-timer commented Apr 28, 2023

Uh oh!

rust-timer commented Apr 28, 2023

Overall result: ❌ regressions - ACTION NEEDED

Instruction count

Max RSS (memory usage)

Cycles

Uh oh!

pnkfelix commented May 3, 2023

Uh oh!

Uh oh!