Close parentheses for offset_of in AST pretty printing
#111037
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HIR pretty printing already handles it correctly.
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
I don't think it's going to conflict with my PR because my PR only changes the top of that match arm's body while yours changes the bottom. But shrug, a rebase is going to be easy one way or another. |
|
r? @compiler-errors @bors r+ rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 1, 2023
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#110823 (Tweak await span to not contain dot) - rust-lang#111015 (Remove wrong assertion in match checking.) - rust-lang#111023 (Test precise capture with a multi-variant enum and exhaustive patterns) - rust-lang#111032 (Migrate `builtin_macros::asm` diagnostics to translatable diagnostics) - rust-lang#111033 (Ping Nadrieril when changing exhaustiveness checking) - rust-lang#111037 (Close parentheses for `offset_of` in AST pretty printing) Failed merges: r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HIR pretty printing already handles it correctly.
This will conflict with #110694 but it seems like that PR is gonna take bit more time.