Skip to content

Emit an error when return-type-notation is used with type/const params #111047

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jun 7, 2023

Conversation

compiler-errors
Copy link
Member

These are not intended to be supported initially, even though the compiler supports them internally...

@rustbot
Copy link
Collaborator

rustbot commented May 1, 2023

r? @lcnr

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 1, 2023
@lcnr
Copy link
Contributor

lcnr commented May 2, 2023

r? types

@rustbot rustbot assigned jackh726 and unassigned lcnr May 2, 2023
@bors
Copy link
Collaborator

bors commented May 4, 2023

☔ The latest upstream changes (presumably #111174) made this pull request unmergeable. Please resolve the merge conflicts.

@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member Author

compiler-errors commented May 19, 2023

@jackh726 do you plan on reviewing this any time soon? otherwise, i'm gonna re-roll.

@bors
Copy link
Collaborator

bors commented May 26, 2023

☔ The latest upstream changes (presumably #111858) made this pull request unmergeable. Please resolve the merge conflicts.

@apiraino
Copy link
Contributor

apiraino commented Jun 1, 2023

I'll do that (hoping it's fine)

r? types

@rustbot rustbot assigned spastorino and unassigned jackh726 Jun 1, 2023
@spastorino
Copy link
Member

@compiler-errors feel free to r=me after resolving conflicts.

@rust-cloud-vms rust-cloud-vms bot force-pushed the rtn-no-ty-ct-params branch from d18b0ee to b0eaaca Compare June 5, 2023 20:33
@compiler-errors
Copy link
Member Author

astconv is apparently too big, so i deleted a method that wasn't really necessary in b0eaaca

@compiler-errors
Copy link
Member Author

@bors r=spastorino

@bors
Copy link
Collaborator

bors commented Jun 5, 2023

📌 Commit b0eaaca has been approved by spastorino

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2023
@bors
Copy link
Collaborator

bors commented Jun 7, 2023

⌛ Testing commit b0eaaca with merge e94bda3...

@bors
Copy link
Collaborator

bors commented Jun 7, 2023

☀️ Test successful - checks-actions
Approved by: spastorino
Pushing e94bda3 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 7, 2023
@bors bors merged commit e94bda3 into rust-lang:master Jun 7, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 7, 2023
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (e94bda3): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
4.8% [4.4%, 5.2%] 2
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-1.3% [-1.3%, -1.3%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) 2.8% [-1.3%, 5.2%] 3

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
- - 0
Improvements ✅
(primary)
-3.7% [-3.7%, -3.7%] 1
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) -3.7% [-3.7%, -3.7%] 1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.017s -> 647.329s (0.05%)

@compiler-errors compiler-errors deleted the rtn-no-ty-ct-params branch August 11, 2023 20:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants