Skip to content

Markfeature(return_position_impl_trait_in_trait) andfeature(async_fn_in_trait) as not incomplete #111048

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 2, 2023

Conversation

compiler-errors
Copy link
Member

I think they've graduated, since as far as I'm aware, they don't cause compiler crashes or unsoundness anymore.

@rustbot
Copy link
Collaborator

rustbot commented May 1, 2023

r? @jackh726

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 1, 2023
@jackh726
Copy link
Member

jackh726 commented May 1, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 1, 2023

📌 Commit 2f2feecd5f4bcbfb34480390a0e9c2ce510bc085 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 1, 2023
@bors
Copy link
Collaborator

bors commented May 2, 2023

☔ The latest upstream changes (presumably #106075) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 2, 2023
@rust-cloud-vms rust-cloud-vms bot force-pushed the rpitit-not-incomplete branch from 2f2feec to 7411468 Compare May 2, 2023 05:11
@compiler-errors
Copy link
Member Author

How coincidental that a PR lands that touches the line directly below one of my feature gates.

@bors r=jackh726

@bors
Copy link
Collaborator

bors commented May 2, 2023

📌 Commit 7411468 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels May 2, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request May 2, 2023
Rollup of 7 pull requests

Successful merges:

 - rust-lang#105076 (Refactor core::char::EscapeDefault and co. structures)
 - rust-lang#108161 (Add `ConstParamTy` trait)
 - rust-lang#108668 (Stabilize debugger_visualizer)
 - rust-lang#110512 (Fix elaboration with associated type bounds)
 - rust-lang#110895 (Remove `all` in target_thread_local cfg)
 - rust-lang#110955 (uplift `clippy::clone_double_ref` as `suspicious_double_ref_op`)
 - rust-lang#111048 (Mark`feature(return_position_impl_trait_in_trait)` and`feature(async_fn_in_trait)` as not incomplete)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 2e3373c into rust-lang:master May 2, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 2, 2023
@compiler-errors compiler-errors deleted the rpitit-not-incomplete branch August 11, 2023 20:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants