Skip to content

Add known issue of let binding to format_args doc #111106

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 15, 2024
Merged

Add known issue of let binding to format_args doc #111106

merged 1 commit into from
Feb 15, 2024

Conversation

Stargateur
Copy link
Contributor

@Stargateur Stargateur commented May 2, 2023 •
edited
Loading

Simply add doc about #92698.

@rustbot label +T-rustdoc -T-libs

r? @GuillaumeGomez

@rustbot
Copy link
Collaborator

rustbot commented May 2, 2023

r? @joshtriplett

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 2, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 2, 2023

Hey! It looks like you've submitted a new PR for the library teams!

If this PR contains changes to any rust-lang/rust public library APIs then please comment with @rustbot label +T-libs-api -T-libs to tag it appropriately. If this PR contains changes to any unstable APIs please edit the PR description to add a link to the relevant API Change Proposal or create one if you haven't already. If you're unsure where your change falls no worries, just leave it as is and the reviewer will take a look and make a decision to forward on if necessary.

Examples of T-libs-api changes:

  • Stabilizing library features
  • Introducing insta-stable changes such as new implementations of existing stable traits on existing stable types
  • Introducing new or changing existing unstable library APIs (excluding permanently unstable features / features without a tracking issue)
  • Changing public documentation in ways that create new stability guarantees
  • Changing observable runtime behavior of library APIs

@rustbot rustbot added T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. and removed T-libs Relevant to the library team, which will review and decide on the PR/issue. labels May 2, 2023
@GuillaumeGomez
Copy link
Member

Since @m-ou-se is the last one who worked on this, I'll let her handle this.

r? @m-ou-se

@rustbot rustbot assigned m-ou-se and unassigned GuillaumeGomez May 2, 2023
m-ou-se
m-ou-se reviewed Jun 21, 2023
View reviewed changes
@fmease
Copy link
Member

fmease commented Sep 4, 2023

@rustbot label -T-rustdoc T-libs A-docs

@rustbot rustbot added A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools T-libs Relevant to the library team, which will review and decide on the PR/issue. and removed T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Sep 4, 2023
@m-ou-se
Copy link
Member

m-ou-se commented Feb 14, 2024

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Feb 14, 2024

📌 Commit cd7c161 has been approved by m-ou-se

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 14, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Feb 15, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2024
@bors
Auto merge of rust-lang#121131 - matthiaskrgr:rollup-mo3b8nz, r=matth…
4ae1e79 
…iaskrgr

Rollup of 10 pull requests

Successful merges:

 - rust-lang#111106 (Add known issue of let binding to format_args doc)
 - rust-lang#118749 (Make contributing to windows bindings easier)
 - rust-lang#120982 (Add APIs for fetching foreign items )
 - rust-lang#121022 (rustdoc: cross-crate re-exports: correctly render late-bound params in source order even if early-bound params are present)
 - rust-lang#121082 (Clarified docs on non-atomic oprations on owned/mut refs to atomics)
 - rust-lang#121084 (Make sure `tcx.create_def` also depends on the forever red node, instead of just `tcx.at(span).create_def`)
 - rust-lang#121098 (Remove unnecessary else block from `thread_local!` expanded code)
 - rust-lang#121105 (Do not report overflow errors on ConstArgHasType goals)
 - rust-lang#121116 (Reinstate some delayed bugs.)
 - rust-lang#121122 (Enforce coroutine-closure layouts are identical)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0238d26 into rust-lang:master Feb 15, 2024
@rustbot rustbot added this to the 1.78.0 milestone Feb 15, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 15, 2024
@rust-timer
Unrolled build for rust-lang#111106
59b4403 
Rollup merge of rust-lang#111106 - Stargateur:doc/format_args, r=m-ou-se

Add known issue of let binding to format_args doc

Simply add doc about rust-lang#92698.

 `@rustbot` label +T-rustdoc -T-libs

 r? `@GuillaumeGomez`
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@m-ou-se m-ou-se m-ou-se left review comments

Assignees

@m-ou-se m-ou-se

Labels
A-docs Area: Documentation for any part of the project, including the compiler, standard library, and tools S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Stargateur @rustbot @GuillaumeGomez @fmease @m-ou-se @bors @joshtriplett