Skip to content

Use free-args consistently in bootstrap #111223

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 5, 2023
Merged

Conversation

jyn514
Copy link
Member

@jyn514 jyn514 commented May 4, 2023

Previously, this was only passed to miri and compiletest. Extended it to all other tests and binaries as well.

cc https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/Running.20a.20single.20doctest

r? @clubby789

Previously, this was only passed to miri and compiletest. Extended it to
all other tests and binaries as well.
@rustbot
Copy link
Collaborator

rustbot commented May 4, 2023

Failed to set assignee to clubby789: invalid assignee

Note: Only org members, users with write permissions, or people who have commented on the PR may be assigned.

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels May 4, 2023
@jyn514 jyn514 self-assigned this May 4, 2023
@jyn514 jyn514 added the A-testsuite Area: The testsuite used to check the correctness of rustc label May 4, 2023
Copy link
Contributor

@clubby789 clubby789 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me - I was thinking about this originally but wasn't quite sure where to change things

@jyn514
Copy link
Member Author

jyn514 commented May 5, 2023

@bors r=clubby789

@bors
Copy link
Collaborator

bors commented May 5, 2023

📌 Commit 0b6a79e has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 5, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request May 5, 2023
Rollup of 8 pull requests

Successful merges:

 - rust-lang#110946 (avoid duplicating TLS state between test std and realstd)
 - rust-lang#110954 (Reject borrows of projections in ConstProp.)
 - rust-lang#111052 (Fix problems with backtraces in two ui tests.)
 - rust-lang#111132 (cleanup nll generalizer)
 - rust-lang#111173 (Still more encoder cleanups)
 - rust-lang#111187 (bootstrap: add llvm-project/runtimes to the sources)
 - rust-lang#111213 (Fixup "since" dates for `array_tuple_conv` feature)
 - rust-lang#111223 (Use `free-args` consistently in bootstrap)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 650dc01 into rust-lang:master May 5, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants