-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Rollup of 7 pull requests #111342
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rollup of 7 pull requests #111342
Conversation
… skip_binder in mir subst methods
also add a suggestion for boxing empty blocks.
… r=BoxyUwU Make `(try_)subst_and_normalize_erasing_regions` take `EarlyBinder` Changes `subst_and_normalize_erasing_regions` and `try_subst_and_normalize_erasing_regions` to take `EarlyBinder<T>` instead of `T`. (related to rust-lang#105779) This was suggested by `@BoxyUwU` in rust-lang#107753 (comment). After changing `type_of` to return `EarlyBinder`, there were several places where the binder was immediately skipped to call `tcx.subst_and_normalize_erasing_regions`, only for the binder to be reconstructed inside of that method. r? `@BoxyUwU`
…wup, r=cjgillot Fix lifetime suggestion for type aliases with objects in them Fixes an issue identified in rust-lang#110761 (comment) This suggestion, like many other borrowck suggestions, are very fragile and there are other ways to trigger strange behavior even after this PR, so this is just a small improvement and not a total rework 💀
…iler-errors Use smaller ints for bitflags Free shrinking!
…=compiler-errors Fix some suggestions where a `Box<T>` is expected. This fixes rust-lang#111011, and also adds a suggestion for boxing a unit type when a `Box<T>` was expected and an empty block was found.
… r=cjgillot Further normalize msvc-non-utf8-ouput Fixes rust-lang#111256 by normalizing this tests down to the essential part so that it only tests for the Unicode output we expect. Also uses a file name that should never occur outside of this test.
…ompiler-errors Make generics_of has_self on RPITITs delegate to the opaque r? `@compiler-errors` I couldn't come up with a test case and none of the ones in the `tests` folder is impacted by this change, but I still think is the right thing to do. Michael, let me know if you have ideas on how to add a test that's affected by this change.
Give a more helpful error when running the rustc shim directly cc https://rust-lang.zulipchat.com/#narrow/stream/326414-t-infra.2Fbootstrap/topic/Building.20.60coretests.60.20by.20hand
@bors r+ rollup=never p=5 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR: previous master: ea0c22ea4f In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (c86e7fb): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 654.179s -> 654.499s (0.05%) |
Successful merges:
(try_)subst_and_normalize_erasing_regions
takeEarlyBinder
#110297 (Make(try_)subst_and_normalize_erasing_regions
takeEarlyBinder
)Box<T>
is expected. #111056 (Fix some suggestions where aBox<T>
is expected.)Failed merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup