Skip to content

Make NonUseContext::AscribeUserTy carry ty::Variance #111366

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 12, 2023

Conversation

obeis
Copy link
Contributor

@obeis obeis commented May 8, 2023

Close #108267

@rustbot
Copy link
Collaborator

rustbot commented May 8, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 8, 2023
@compiler-errors
Copy link
Member

r? @lcnr

@rustbot rustbot assigned lcnr and unassigned compiler-errors May 8, 2023
@obeis obeis force-pushed the ascribe-user-type-variance branch from dd0e43b to 2198fae Compare May 10, 2023 06:56
@obeis obeis requested a review from lcnr May 10, 2023 07:39
@lcnr
Copy link
Contributor

lcnr commented May 11, 2023

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented May 11, 2023

📌 Commit 2198fae has been approved by lcnr

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 11, 2023
Dylan-DPC added a commit to Dylan-DPC/rust that referenced this pull request May 11, 2023
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request May 11, 2023
…r=lcnr

Make `NonUseContext::AscribeUserTy` carry `ty::Variance`

Close rust-lang#108267
bors added a commit to rust-lang-ci/rust that referenced this pull request May 12, 2023
…mpiler-errors

Rollup of 7 pull requests

Successful merges:

 - rust-lang#106038 (use implied bounds when checking opaque types)
 - rust-lang#111366 (Make `NonUseContext::AscribeUserTy` carry `ty::Variance`)
 - rust-lang#111375 (CFI: Fix SIGILL reached via trait objects)
 - rust-lang#111439 (Fix backtrace normalization in ice-bug-report-url.rs)
 - rust-lang#111444 (Only warn single-use lifetime when the binders match.)
 - rust-lang#111459 (Update browser-ui-test version to 0.16.0)
 - rust-lang#111460 (Improve suggestion for `self: Box<self>`)

Failed merges:

 - rust-lang#110454 (Require impl Trait in associated types to appear in method signatures)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 41ab8e6 into rust-lang:master May 12, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 12, 2023
@obeis obeis deleted the ascribe-user-type-variance branch May 13, 2023 12:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AscribeUserType statements contain variance which should be carried by NonUseContext::AscribeUserTy
6 participants