-
Notifications
You must be signed in to change notification settings - Fork 13.1k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Don't force include Windows goop when documenting #111401
Conversation
(rustbot has picked a reviewer for you, use r? to override) |
Hey! It looks like you've submitted a new PR for the library teams! If this PR contains changes to any Examples of
|
|
@bors r+ rollup=iffy |
It works fine for LoongArch. Thank you! ❤️ |
Bumping priority because the issue this fixes is affecting a number of tier 3 targets @bors p=1 |
☀️ Test successful - checks-actions |
Finished benchmarking commit (cba1407): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 660.093s -> 658.519s (-0.24%) |
Looks like this issue is now fixed on s390x as well - thanks! |
…jubilee Remove unnecessary `path` attribute Follow up to rust-lang#111401. I missed this at the time but it should now be totally unnecessary since the other include was removed. r? `@workingjubilee`
Why do we need to include all the windows bits on non-windows platforms? Let's try not doing that.
Possible alternative to #111394, if it works.