Skip to content

Use visit_assign to detect SSA locals. #111432

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
May 11, 2023
Merged

Conversation

cjgillot
Copy link
Contributor

I screwed up the logic in 3c43b61.

Fixes #111426

@rustbot
Copy link
Collaborator

rustbot commented May 10, 2023

r? @petrochenkov

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels May 10, 2023
@rustbot
Copy link
Collaborator

rustbot commented May 10, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@petrochenkov
Copy link
Contributor

r? rust-lang/compiler

@rustbot rustbot assigned wesleywiser and unassigned petrochenkov May 10, 2023
@oli-obk
Copy link
Contributor

oli-obk commented May 10, 2023

@bors r+

@bors
Copy link
Collaborator

bors commented May 10, 2023

📌 Commit 6ad0497 has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented May 10, 2023

🌲 The tree is currently closed for pull requests below priority 50. This pull request will be tested once the tree is reopened.

@bors bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 10, 2023
@oli-obk
Copy link
Contributor

oli-obk commented May 10, 2023

r? @oli-obk

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 10, 2023
@rustbot rustbot assigned oli-obk and unassigned wesleywiser May 10, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request May 11, 2023
…iaskrgr

Rollup of 7 pull requests

Successful merges:

 - rust-lang#108705 (Prevent ICE with broken borrow in closure)
 - rust-lang#111292 (Fix mishandled `--check-cfg` arguments order)
 - rust-lang#111382 (Isolate coverage FFI type layouts from their underlying LLVM C++ types)
 - rust-lang#111385 (vec-shrink-panik: update expectations to work on LLVM 17)
 - rust-lang#111389 (Add esp-idf platform-support page)
 - rust-lang#111432 (Use visit_assign to detect SSA locals.)
 - rust-lang#111448 (Use proper impl self type for alias impl in rustdoc)

Failed merges:

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 968911d into rust-lang:master May 11, 2023
@rustbot rustbot added this to the 1.71.0 milestone May 11, 2023
@cjgillot cjgillot deleted the issue-111426 branch May 11, 2023 16:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferencePropagation MIR opt prevents partial initialisation in MIR
6 participants