Add timings for MIR passes to profiling report #111619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred to MIR optimizations cc @rust-lang/wg-mir-opt |
|
@bors r=WaffleLapkin |
bors
added
S-waiting-on-bors
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 16, 2023
Add timings for MIR passes to profiling report This will help identify which pass is responsible for a regression.
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
May 19, 2023
Add timings for MIR passes to profiling report This will help identify which pass is responsible for a regression.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2023
Rollup of 10 pull requests Successful merges: - rust-lang#111491 (Dont check `must_use` on nested `impl Future` from fn) - rust-lang#111606 (very minor cleanups) - rust-lang#111619 (Add timings for MIR passes to profiling report) - rust-lang#111652 (Better diagnostic for `use Self::..`) - rust-lang#111665 (Add more tests for the offset_of macro) - rust-lang#111708 (Give a more useful location for where a span_bug was delayed) - rust-lang#111715 (Fix doc comment for `ConstParamTy` derive) - rust-lang#111723 (style: do not overwrite obligations) - rust-lang#111743 (Improve cgu merging debug output) - rust-lang#111762 (fix: emit error when fragment is `MethodReceiverExpr` and items is empty) r? `@ghost` `@rustbot` modify labels: rollup
Zoxc
reviewed
Aug 19, 2023
| @@ -121,7 +121,7 @@ fn run_passes_inner<'tcx>( | |||
| validate_body(tcx, body, format!("before pass {}", name)); | |||
| } | |||
|
|
|||
| pass.run_pass(tcx, body); | |||
| tcx.sess.time(name, || pass.run_pass(tcx, body)); | |||
There was a problem hiding this comment.
This should be using generic_activity or generic_activity_with_arg to avoid printing lots of MIR passes on stderr.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help identify which pass is responsible for a regression.