debug format Const's less verbosely
#111630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
compiler-errors
approved these changes
May 16, 2023
|
@bors r+ |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
|
@bors r- r=me tests blessed |
bors
added
S-waiting-on-author
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
This comment has been minimized.
This comment has been minimized.
Dylan-DPC
added a commit
to Dylan-DPC/rust
that referenced
this pull request
May 16, 2023
… r=compiler-errors
debug format `Const`'s less verbosely
Not user visible change only visible to people debugging const generics.
Currently debug output for `ty::Const` is super verbose (even for `-Zverbose` lol), things like printing infer vars as `Infer(Var(?0c))` instead of just `?0c`, bound vars and placeholders not using `^0_1` or `!0_1` syntax respectively. With these changes its imo better but not perfect:
`Const { ty: usize, kind: ^0_1 }`
is still a lot for not much information. not entirely sure what to do about that so not dealing with it yet.
Need to do formatting for `ConstKind::Expr` at some point too since rn it sucks (doesn't even print anything with `Display`) not gonna do that in this PR either.
r? `@compiler-errors`
|
@bors r- |
bors
added
S-waiting-on-author
BoxyUwU
force-pushed
the
ty_const_debug_formatting
branch
from
d983b11 to
2a554eb
Compare
|
@bors rollup=never (because apparently changing debug formatting is really hard to get right! 🙄) |
|
@bors r=compiler-errors |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (6c64870): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 643.756s -> 643.359s (-0.06%) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not user visible change only visible to people debugging const generics.
Currently debug output for
ty::Constis super verbose (even for-Zverboselol), things like printing infer vars asInfer(Var(?0c))instead of just?0c, bound vars and placeholders not using^0_1or!0_1syntax respectively. With these changes its imo better but not perfect:Const { ty: usize, kind: ^0_1 }is still a lot for not much information. not entirely sure what to do about that so not dealing with it yet.
Need to do formatting for
ConstKind::Exprat some point too since rn it sucks (doesn't even print anything withDisplay) not gonna do that in this PR either.r? @compiler-errors