-
Notifications
You must be signed in to change notification settings - Fork 13.3k
Make TrustedStep
require Copy
#112083
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Make TrustedStep
require Copy
#112083
Conversation
All the implementations of the trait already are `Copy`, and this seems to be enough to simplify the implementations enough to make the MIR inliner willing to inline basics like `Range::next`.
Looks nice. @bors r+ rollup=never |
This comment has been minimized.
This comment has been minimized.
@bors r- |
The Miri subtree was changed cc @rust-lang/miri |
@bors r=thomcc |
☀️ Test successful - checks-actions |
Finished benchmarking commit (578bcbc): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 645.491s -> 642.797s (-0.42%) |
Remove uneeded clones now that TrustedStep implies Copy This is a follow up to 11fa176 (from rust-lang#112083)
Rollup merge of rust-lang#123859 - krtab:uneeded_clone, r=cuviper Remove uneeded clones now that TrustedStep implies Copy This is a follow up to 11fa176 (from rust-lang#112083)
All the implementations of the trait already are
Copy
, and this seems to be enough to simplify the implementations enough to make the MIR inliner willing to inline basics likeRange::next
.r? @thomcc