Skip to content

Disable RustAnalyzer check by default, run Rustfmt check before #112291

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 5, 2023
Merged

Disable RustAnalyzer check by default, run Rustfmt check before #112291

merged 2 commits into from
Jun 5, 2023

Conversation

sigaloid
Copy link
Contributor

@sigaloid sigaloid commented Jun 4, 2023

Fixes #112287.

@rustbot
Copy link
Collaborator

rustbot commented Jun 4, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) labels Jun 4, 2023
@clubby789
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 5, 2023

📌 Commit 7ed7e20 has been approved by clubby789

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 5, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 5, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 5, 2023
@bors
Auto merge of rust-lang#112317 - GuillaumeGomez:rollup-toh0gpo, r=Gui…
408bbd0 
…llaumeGomez

Rollup of 6 pull requests

Successful merges:

 - rust-lang#112243 (Remove unneeded `Buffer` allocations when `&mut fmt::Write` can be used directly)
 - rust-lang#112263 (Remove ExtendElement, ExtendWith, extend_with)
 - rust-lang#112291 (Disable RustAnalyzer check by default, run Rustfmt check before)
 - rust-lang#112299 (Don't double-print status messages in GHA)
 - rust-lang#112311 (Ignore fluent message reordering in `git blame`)
 - rust-lang#112315 (fix spelling error)

Failed merges:

 - rust-lang#112251 (rustdoc: convert `if let Some()` that always matches to variable)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 0258a16 into rust-lang:master Jun 5, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 5, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@KittyBorgX KittyBorgX KittyBorgX approved these changes

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

x check checks rust-analyzer by default
6 participants
@sigaloid @rustbot @clubby789 @bors @KittyBorgX @Mark-Simulacrum