Test x86_64-gnu in PR CI, not x86_64-gnu-llvm-14
#112296
Conversation
rustbot
added
A-testsuite
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
|
When I changed codegen tests, CI running old LLVM was useful because it immediately made me aware that I forgot to make them old LLVM compatible (typed pointers 😿). But that problem should get a lot smaller once we finally drop support for typed pointer LLVM. |
|
@Nilstrieb I think that's okay, because the issue goes both ways. If we're testing llvm-14, we don't see codegen test failures for the current LLVM version in PRs, so one of the configurations will not be covered either way, and I'm not sure the llvm-14 configuration is inherently more valuable from that perspective. Fixing llvm-N failures is usually just a matter of slapping |
|
Well, I assume that |
This is a pre-requisite for rust-lang#112143, which wants to start using download-rustc in PRs. download-rustc doesn't allow providing an external LLVM.
this was a pre-existing latent bug, we just didn't have any CI builders exercising it.
fixes the following errors:
```
---- [ui] tests/ui/sanitize/new-llvm-pass-manager-thin-lto.rs#opt1 stdout ----
error in revision `opt1`: test compilation failed although it shouldn't!
status: exit status: 1
command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/tests/ui/sanitize/new-llvm-pass-manager-thin-lto.rs" "-Zthreads=1" "-Zsimulate-remapped-rust-src-base=/rustc/FAKE_PREFIX" "-Ztranslate-remapped-path-to-local-path=no" "--sysroot" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2" "--target=i686-unknown-linux-gnu" "--cfg" "opt1" "--error-format" "json" "--json" "future-incompat" "-Ccodegen-units=1" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-Cstrip=debuginfo" "--remap-path-prefix=/checkout/tests/ui=fake-test-src-base" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitize/new-llvm-pass-manager-thin-lto.opt1/a" "-A" "unused" "-Crpath" "-Cdebuginfo=0" "-Lnative=/checkout/obj/build/i686-unknown-linux-gnu/native/rust-test-helpers" "-Clinker=x86_64-linux-gnu-gcc" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/sanitize/new-llvm-pass-manager-thin-lto.opt1/auxiliary" "-Zsanitizer=address" "-Clto=thin" "-Copt-level=1"
--- stderr -------------------------------
error: linking with `x86_64-linux-gnu-gcc` failed: exit status: 1
= note: x86_64-linux-gnu-gcc: error: /checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/i686-unknown-linux-gnu/lib/librustc-nightly_rt.asan.a: No such file or directory
failures:
[ui] tests/ui/sanitize/badfree.rs
[ui] tests/ui/sanitize/address.rs
[ui] tests/ui/sanitize/use-after-scope.rs
[ui] tests/ui/sanitize/new-llvm-pass-manager-thin-lto.rs#opt0
[ui] tests/ui/sanitize/new-llvm-pass-manager-thin-lto.rs#opt1
```
jyn514
added
S-experimental
|
closing in favor of #112143 |
This is a pre-requisite for #112143, which wants to start using download-rustc in PRs. download-rustc doesn't allow providing an external LLVM.
r? @ghost