Skip to content

Avoid duplicate type sanitization of local decls in borrowck #112350

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

Noratrieb
Copy link
Member

The type of the local decl is already sanitized in visit_local_decl.

@rustbot
Copy link
Collaborator

rustbot commented Jun 6, 2023

r? @oli-obk

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 6, 2023
@compiler-errors
Copy link
Member

maybe worth a comment left in its place stating this? r=me otherwise

r? @compiler-errors

@rustbot rustbot assigned compiler-errors and unassigned oli-obk Jun 6, 2023
The type of the local decl is already sanitized in `visit_local_decl`.
@rust-cloud-vms rust-cloud-vms bot force-pushed the borrow-me-some-cleanups branch from 8c1d57a to 5593e7e Compare June 6, 2023 18:52
@Noratrieb
Copy link
Member Author

@bors r=compiler-errors rollup

@bors
Copy link
Collaborator

bors commented Jun 6, 2023

📌 Commit 5593e7e has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 6, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 6, 2023
…iaskrgr

Rollup of 8 pull requests

Successful merges:

 - rust-lang#111250 (Add Terminator conversion from MIR to SMIR, part #2)
 - rust-lang#112310 (Add new Tier-3 targets: `loongarch64-unknown-none*`)
 - rust-lang#112334 (Add myself to highfive rotation)
 - rust-lang#112340 (remove `TyCtxt::has_error_field` helper method)
 - rust-lang#112343 (Prevent emitting `missing_docs` for `pub extern crate`)
 - rust-lang#112350 (Avoid duplicate type sanitization of local decls in borrowck)
 - rust-lang#112356 (Fix comment for `get_region_var_origins`)
 - rust-lang#112358 (Remove default visitor impl in region constraint generation)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit fd6efcf into rust-lang:master Jun 7, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 7, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants