Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Ignore tests that hang in new solver #112481

Merged
merged 1 commit into from
Jun 10, 2023
Merged

Ignore tests that hang in new solver #112481

merged 1 commit into from
Jun 10, 2023

Conversation

compiler-errors
Copy link
Member

This makes it easier to run --compare-mode=next-solver, and we can revisit these tests later to find out how to make them less overflowy 😅

r? @lcnr

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 10, 2023
@lqd
Copy link
Member

lqd commented Jun 10, 2023

I also wanted to do this to make --compare-mode=next-solver more helpful, so you can r=me if you want.

@compiler-errors
Copy link
Member Author

@bors r=lqd rollup

@bors
Copy link
Contributor

bors commented Jun 10, 2023

📌 Commit 3152ac3 has been approved by lqd

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 10, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 10, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 10, 2023
@bors
Auto merge of rust-lang#112485 - matthiaskrgr:rollup-ta84xje, r=matth…
4b71d79 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#110141 (expand: Change how `#![cfg(FALSE)]` behaves on crate root)
 - rust-lang#112369 (More CGU cleanups)
 - rust-lang#112467 (Compile rustc_driver by default)
 - rust-lang#112468 (Change format of rustdoc-js tests by putting query and correction directly alongside the expected values)
 - rust-lang#112473 (Update cargo)
 - rust-lang#112481 (Ignore tests that hang in new solver)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit dcdfff6 into rust-lang:master Jun 10, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 10, 2023
@lcnr lcnr added the WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver) label Jun 11, 2023
@compiler-errors compiler-errors deleted the new-solver-ignore-bad-tests branch August 11, 2023 20:09
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@lcnr lcnr

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. WG-trait-system-refactor The Rustc Trait System Refactor Initiative (-Znext-solver)
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
5 participants
@compiler-errors @lqd @bors @lcnr @rustbot