Skip to content

Make Bound::predicates use Clause #112734

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Conversation

dswij
Copy link
Member

@dswij dswij commented Jun 17, 2023

Part of #107250

Bound::predicates returns an iterator over Binder<_, Clause> instead of Predicate.

I tried updating explicit_predicates_of as well, but it seems that it needs a lot more change than I thought. Will do it in a separate PR instead.

@rustbot
Copy link
Collaborator

rustbot commented Jun 17, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 17, 2023
@dswij
Copy link
Member Author

dswij commented Jun 17, 2023

r? @oli-obk

@rustbot rustbot assigned oli-obk and unassigned cjgillot Jun 17, 2023
@compiler-errors
Copy link
Member

r? @compiler-errors @bors r+

@bors
Copy link
Collaborator

bors commented Jun 17, 2023

📌 Commit f874345 has been approved by compiler-errors

It is now in the queue for this repository.

@rustbot rustbot assigned compiler-errors and unassigned oli-obk Jun 17, 2023
@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 17, 2023
@compiler-errors
Copy link
Member

@dswij: I pinged you on Zulip to discuss how this PR (and future work you've already gotten started on/are planning on doing) fits together with the design I drafted out for ty::Clause in #112714. If you have an alternative way that you prefer to chat, let me know.

compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 18, 2023
…compiler-errors

Make `Bound::predicates`  use `Clause`

Part of rust-lang#107250

`Bound::predicates` returns an iterator over `Binder<_, Clause>` instead of `Predicate`.

I tried updating `explicit_predicates_of` as well, but it seems that it needs a lot more change than I thought. Will do it in a separate PR instead.
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 18, 2023
…compiler-errors

Make `Bound::predicates`  use `Clause`

Part of rust-lang#107250

`Bound::predicates` returns an iterator over `Binder<_, Clause>` instead of `Predicate`.

I tried updating `explicit_predicates_of` as well, but it seems that it needs a lot more change than I thought. Will do it in a separate PR instead.
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 18, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#107200 (io: soften ‘at most one write attempt’ requirement in io::Write::write)
 - rust-lang#112667 (Move WF/ConstEvaluatable goal to clause)
 - rust-lang#112685 (std: only depend on dlmalloc for wasm*-unknown)
 - rust-lang#112722 (bootstrap: check for dry run when copying env vars for msvc)
 - rust-lang#112734 (Make `Bound::predicates`  use `Clause`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3436069 into rust-lang:master Jun 18, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 18, 2023
@dswij dswij deleted the bounds-predicates-clause branch June 18, 2023 18:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants