Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Make closure_saved_names_of_captured_variables a query. #112759

Merged
merged 3 commits into from
Jun 21, 2023
Merged

Make closure_saved_names_of_captured_variables a query. #112759

merged 3 commits into from
Jun 21, 2023

Conversation

cjgillot
Copy link
Contributor

As we will start removing debuginfo during MIR optimizations, we need to keep them somewhere.

@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2023

r? @compiler-errors

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jun 18, 2023
@rustbot
Copy link
Collaborator

rustbot commented Jun 18, 2023

Some changes occurred to MIR optimizations

cc @rust-lang/wg-mir-opt

@oli-obk
Copy link
Contributor

oli-obk commented Jun 19, 2023

@bors r+ r? @oli-obk

@bors
Copy link
Contributor

bors commented Jun 19, 2023

📌 Commit 689607e has been approved by oli-obk

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 19, 2023
@bors
Copy link
Contributor

bors commented Jun 20, 2023

⌛ Testing commit 689607e with merge 1c25a56c6b762b4e2b67e5a9ba493b856162a751...

@rust-log-analyzer
Copy link
Collaborator

The job i686-msvc failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot) 
extracting C:\a\rust\rust\build\cache\2023-05-30\rust-std-beta-x86_64-unknown-linux-gnu.tar.xz to C:\a\rust\rust\build\x86_64-unknown-linux-gnu\stage0
downloading https://static.rust-lang.org/dist/2023-05-30/rustc-beta-x86_64-unknown-linux-gnu.tar.xz
extracting C:\a\rust\rust\build\cache\2023-05-30\rustc-beta-x86_64-unknown-linux-gnu.tar.xz to C:\a\rust\rust\build\x86_64-unknown-linux-gnu\stage0
downloading https://static.rust-lang.org/dist/2023-05-30/cargo-beta-x86_64-unknown-linux-gnu.tar.xz
thread 'config::tests::download_ci_llvm' panicked at 'status code: 1', C:\a\rust\rust\src\tools\build_helper\src\util.rs:16:9

failures:
    config::tests::download_ci_llvm


test result: FAILED. 28 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 121.83s

error: test failed, to rerun pass `--lib`
Build completed unsuccessfully in 1:15:21
make: *** [Makefile:66: ci-msvc-ps1] Error 1

@bors
Copy link
Contributor

bors commented Jun 20, 2023

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 20, 2023
@oli-obk
Copy link
Contributor

oli-obk commented Jun 20, 2023

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 20, 2023
compiler-errors added a commit to compiler-errors/rust that referenced this pull request Jun 20, 2023
@compiler-errors
Rollup merge of rust-lang#112759 - cjgillot:closure-names, r=oli-obk
9bf3022 
Make closure_saved_names_of_captured_variables a query.

As we will start removing debuginfo during MIR optimizations, we need to keep them somewhere.
@compiler-errors compiler-errors mentioned this pull request Jun 20, 2023
Closed
@Noratrieb Noratrieb mentioned this pull request Jun 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 21, 2023
@bors
Auto merge of rust-lang#112877 - Nilstrieb:rollup-5g5hegl, r=Nilstrieb
97bf23d 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#112632 (Implement PartialOrd for `Vec`s over different allocators)
 - rust-lang#112759 (Make closure_saved_names_of_captured_variables a query. )
 - rust-lang#112772 (Add a fully fledged `Clause` type, rename old `Clause` to `ClauseKind`)
 - rust-lang#112790 (Syntactically accept `become` expressions (explicit tail calls experiment))
 - rust-lang#112830 (More codegen cleanups)
 - rust-lang#112844 (Add retag in MIR transform: `Adt` for `Unique` may contain a reference)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 34c8e53 into rust-lang:master Jun 21, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 21, 2023
@cjgillot cjgillot deleted the closure-names branch June 21, 2023 11:29
flip1995 pushed a commit to flip1995/rust that referenced this pull request Jun 30, 2023
@bors
Auto merge of rust-lang#112877 - Nilstrieb:rollup-5g5hegl, r=Nilstrieb
a2b99d8 
Rollup of 6 pull requests

Successful merges:

 - rust-lang#112632 (Implement PartialOrd for `Vec`s over different allocators)
 - rust-lang#112759 (Make closure_saved_names_of_captured_variables a query. )
 - rust-lang#112772 (Add a fully fledged `Clause` type, rename old `Clause` to `ClauseKind`)
 - rust-lang#112790 (Syntactically accept `become` expressions (explicit tail calls experiment))
 - rust-lang#112830 (More codegen cleanups)
 - rust-lang#112844 (Add retag in MIR transform: `Adt` for `Unique` may contain a reference)

r? `@ghost`
`@rustbot` modify labels: rollup
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@oli-obk oli-obk oli-obk requested changes

Assignees

@oli-obk oli-obk

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
6 participants
@cjgillot @rustbot @oli-obk @bors @rust-log-analyzer @compiler-errors