Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix union fields display #112894

Merged
merged 2 commits into from
Jun 21, 2023
Merged

Fix union fields display #112894

merged 2 commits into from
Jun 21, 2023

Conversation

GuillaumeGomez
Copy link
Member

@GuillaumeGomez GuillaumeGomez commented Jun 21, 2023 •
edited
Loading

Screenshot from 2023-06-21 16-47-24

So two bugs in this screenshot: no whitespace between field name and type name, both fields are on the same line. Both problems come from issues in the templates because all whitespace are removed if a askama "command" follows.

r? @notriddle

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 21, 2023
@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Jun 21, 2023

📌 Commit 805edb0 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 21, 2023
@GuillaumeGomez GuillaumeGomez mentioned this pull request Jun 21, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 21, 2023
@bors
Auto merge of rust-lang#112900 - GuillaumeGomez:rollup-1blf4io, r=Gui…
065a1f5 
…llaumeGomez

Rollup of 4 pull requests

Successful merges:

 - rust-lang#112538 (Removed unnecessary &String -> &str, now that &String implements StableOrd as well)
 - rust-lang#112868 (Liberate bound vars properly when suggesting missing async-fn-in-trait)
 - rust-lang#112892 (resolve: Minor cleanup to `fn resolve_path_with_ribs`)
 - rust-lang#112894 (Fix union fields display)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f5470af into rust-lang:master Jun 21, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 21, 2023
@GuillaumeGomez GuillaumeGomez deleted the gui-fields-display branch June 22, 2023 08:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@notriddle notriddle notriddle approved these changes

Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @notriddle @bors @rustbot