Skip to content

rustdoc: render the body of associated types before the where-clause #112906

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 22, 2023
Merged

rustdoc: render the body of associated types before the where-clause #112906

merged 1 commit into from
Jun 22, 2023

Conversation

fmease
Copy link
Member

@fmease fmease commented Jun 21, 2023

Fixes #112903.

@rustbot
Copy link
Collaborator

rustbot commented Jun 21, 2023

r? @notriddle

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue. labels Jun 21, 2023
compiler-errors
compiler-errors approved these changes Jun 21, 2023
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I obviously didn't know what I was doing when I added GAT support to rustdoc :clueless:

@notriddle
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Jun 22, 2023

📌 Commit b866113 has been approved by notriddle

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 22, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Jun 22, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Jun 22, 2023
@bors
Auto merge of rust-lang#112914 - matthiaskrgr:rollup-f0kdqh9, r=matth…
0928a1f 
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#112876 (Don't substitute a GAT that has mismatched generics in `OpaqueTypeCollector`)
 - rust-lang#112906 (rustdoc: render the body of associated types before the where-clause)
 - rust-lang#112907 (Update cargo)
 - rust-lang#112908 (Print def_id on EarlyBoundRegion debug)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 3ba66df into rust-lang:master Jun 22, 2023
@rustbot rustbot added this to the 1.72.0 milestone Jun 22, 2023
@fmease fmease deleted the rustdoc-render-assoc-ty-body-before-where-clause branch June 22, 2023 08:39
@fmease
Copy link
Member Author

fmease commented Jun 22, 2023 •
edited
Loading

I obviously didn't know what I was doing when I added GAT support to rustdoc :clueless:

All good, at the time you added that support (#94009), #89122 wasn't approved yet / fixed by #90076.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@compiler-errors compiler-errors compiler-errors approved these changes

Assignees

@notriddle notriddle

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-rustdoc Relevant to the rustdoc team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.72.0
Development

Successfully merging this pull request may close these issues.

rustdoc should render the body of assoc tys *before* the where-clause
5 participants
@fmease @rustbot @notriddle @bors @compiler-errors