-
Notifications
You must be signed in to change notification settings - Fork 13.4k
add check for ConstKind::Value(_) to in_operand() #113107
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Conversation
r? @davidtwco (rustbot has picked a reviewer for you, use r? to override) |
should I add a copy the example from the issue into a test? |
It's not wronger than the code path for |
r? @oli-obk |
bc8fe15
to
71362c7
Compare
Happy to do any work on that if it would be helpful, although I probably would need some guidance |
@bors r+ rollup
I believe the |
Ok great I can give that a go |
Rollup of 5 pull requests Successful merges: - rust-lang#112946 (Improve cgu naming and ordering) - rust-lang#113048 (Fix build on Solaris where fd-lock cannot be used.) - rust-lang#113100 (Fix display of long items in search results) - rust-lang#113107 (add check for ConstKind::Value(_) to in_operand()) - rust-lang#113119 (rustdoc: Reduce internal function visibility.) r? `@ghost` `@rustbot` modify labels: rollup
Added check for valtree value to close #113012 which fixes the issue, although I am not sure if adding the check there is sound or not cc @oli-obk