Make the Elaboratable trait take clauses
#113144
Merged
+42
−40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @eholk (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
r? @oli-obk (since you've been reviewing the clause rewrite code) |
|
Is there a chance we'll be able to remove the @bors r+ rollup |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jun 29, 2023
… r=oli-obk Make the `Elaboratable` trait take clauses We only ever elaborate clauses, so make this explicit in the trait's definition rather than having a bunch of `.expect_clause()` calls everywhere.
compiler-errors
added a commit
to compiler-errors/rust
that referenced
this pull request
Jun 30, 2023
… r=oli-obk Make the `Elaboratable` trait take clauses We only ever elaborate clauses, so make this explicit in the trait's definition rather than having a bunch of `.expect_clause()` calls everywhere.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 30, 2023
…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#111322 (Support for native WASM exceptions) - rust-lang#112086 (resolve: Remove artificial import ambiguity errors) - rust-lang#112234 (refactor `tool_doc!`) - rust-lang#112300 (Convert `run-make/coverage-reports` tests to use a custom compiletest mode) - rust-lang#112795 (Migrate some rustc_builtin_macros to SessionDiagnostic) - rust-lang#113144 (Make the `Elaboratable` trait take clauses) - rust-lang#113161 (Fix type privacy lints error message) r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We only ever elaborate clauses, so make this explicit in the trait's definition rather than having a bunch of
.expect_clause()calls everywhere.