Rollup of 8 pull requests #113256
Merged
Rollup of 8 pull requests #113256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Li Zhanhui <lizhanhui@gmail.com>
The args for unittest and cargo test are mutually incompatible. Suggest that people use `python -m unittest ...` manually instead. This also changes `bootstrap_test.py` to be easier to run standalone; see the commit for details.
…oc_example, r=Mark-Simulacrum Fix document examples of Vec::from_raw_parts and Vec::from_raw_parts_in These two examples are misplaced.
…ubilee std docs: factorize literal in Barrier example Motivated by https://www.reddit.com/r/rust/comments/rnh5hu/barrier_question_barrier_does_not_sync_many/ (but maybe not worth it?)
…lor-18, r=notriddle Migrate GUI colors test to original CSS color format Follow-up of rust-lang#111459. r? ``@notriddle``
…, r=Nilstrieb Fix `dropping_copy_types` lint from linting in match-arm with side-effects This PR fixes an issue with the `dropping_copy_types` and `dropping_references` lints when not all patterns that can have side-effects were detected and ignored. Nearly _fixes_ rust-lang#112653 (will need beta-backport to completely fix the issue) r? ``@Nilstrieb``
Update chalk For rust-lang#109302 r? jackh726
…clubby789 Don't pass --test-args to `python -m unitest` The args for unittest and cargo test are mutually incompatible. Suggest that people use `python -m unittest ...` manually instead. This also changes `bootstrap_test.py` to be easier to run standalone; see the commit for details. r? `@clubby789` cc rust-lang#112281 (comment)
…ts, r=jyn514 Make Rust Analyzer tests faster by compiling less code This should bring down the test duration of RA significantly.
Document tracking issue for rustdoc `show-type-layout` Tracking issue: rust-lang#113248 ``@rustbot`` label +T-rustdoc +A-docs
rustbot
added
S-waiting-on-review
|
@bors r+ rollup=never p=8 |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
📌 Perf builds for each rolled up PR:
previous master: 72b2101434 In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
This was referenced Jul 2, 2023
Merged
Merged
|
Finished benchmarking commit (4c3f8c7): comparison URL. Overall result: ❌ regressions - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 662.283s -> 662.06s (-0.03%) |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
dropping_copy_typeslint from linting in match-arm with side-effects #113231 (Fixdropping_copy_typeslint from linting in match-arm with side-effects)python -m unitest#113234 (Don't pass --test-args topython -m unitest)show-type-layout#113249 (Document tracking issue for rustdocshow-type-layout)r? @ghost
@rustbot modify labels: rollup
Create a similar rollup