implement ConstEvaluatable goals in new solver
#113324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred to the core trait solver cc @rust-lang/initiative-trait-system-refactor |
BoxyUwU
reviewed
Jul 4, 2023
This comment has been minimized.
This comment has been minimized.
we don't yet handle `generic_const_exprs`, someone else can do that :3
lcnr
force-pushed
the
const-evaluatable-goal
branch
from
fa73b02 to
abcaf30
Compare
|
@bors r=BoxyUwU rollup |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 4, 2023
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#113192 (`assemble_candidates_after_normalizing_self_ty` docs) - rust-lang#113251 (Use scoped-tls for SMIR to map between TyCtxt and SMIR datastructures) - rust-lang#113282 (Update platform-support.md to improve ARM target descriptions) - rust-lang#113296 (add flag for enabling global cache usage for proof trees and printing proof trees on error) - rust-lang#113324 (implement `ConstEvaluatable` goals in new solver) r? `@ghost` `@rustbot` modify labels: rollup
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this only supports stable const generics.
feature(generic_const_exprs)needs to extend that function is non-trivial ways. Leaving this for someone else or some later date.r? @BoxyUwU